[17.0][MIG] sale_loyalty_limit: Migration to 17.0 #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We add some compute fields to check the current promotion usage by the limited users. That allows us to refactor the check method a little bit as well unifying the logic. TT30847
Coupons are reset when a sale order is cancelled, but applied programs remain linked to the cancelled order. As they're cancelled, we should not count them in the limits. TT34264
Sometimes Odoo doesn't remove the rules properly until the promotions are refreshed. This could lead to count mismatches. We wan't to ensure the count looking at the lines instead. TT34266
For complying with rules.
Simplify rule and ensure compatibility with sale_coupon_multiple_code_program wich allows to use multiple code programs putting them in the no code promotions many2many field.
Allow coupon_limit settings to be used by other loyalty modules
Currently translated at 100.0% (9 of 9 strings) Translation: sale-promotion-15.0/sale-promotion-15.0-sale_coupon_limit Translate-URL: https://translation.odoo-community.org/projects/sale-promotion-15-0/sale-promotion-15-0-sale_coupon_limit/it/
Currently translated at 100.0% (7 of 7 strings) Translation: sale-promotion-16.0/sale-promotion-16.0-sale_loyalty_limit Translate-URL: https://translation.odoo-community.org/projects/sale-promotion-16-0/sale-promotion-16-0-sale_loyalty_limit/it/
arantxa-s73
force-pushed
the
17.0-mig-sale_loyalty_limit
branch
2 times, most recently
from
3cd4768 to
7667a96
Compare
arantxa-s73
force-pushed
the
17.0-mig-sale_loyalty_limit
branch
from
7667a96 to
2a57326
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Module migrated to version 17.0
Depends on: