Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0][FIX] hr_employee_birthay_mail: res_users configurable #1267

Open
wants to merge 1 commit into
base: 14.0
Choose a base branch
from

Conversation

JoanSForgeFlow
Copy link

This PR allows each user to grant permission for anniversary notifications from "My profile", otherwise only HR administrators can edit it.

The group "hr.group_hr_user" is also added. Without this group, the open attendances at that time fail and do not allow the attendance session to be closed.

@ForgeFlow

@JoanSForgeFlow JoanSForgeFlow force-pushed the 14.0-fix-hr_employee_birthay_mail-res_users branch from 3fdddda to e69160f Compare July 10, 2023 08:48
Copy link

@JordiMForgeFlow JordiMForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼

@JoanSForgeFlow JoanSForgeFlow changed the title [FIX] hr_employee_birthay_mail: res_users configurable [14.0][FIX] hr_employee_birthay_mail: res_users configurable Jul 10, 2023
Copy link

@mariadforgeflow mariadforgeflow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@dreispt
Copy link
Sponsor Member

dreispt commented Nov 2, 2023

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 14.0-ocabot-merge-pr-1267-by-dreispt-bump-minor, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Nov 2, 2023
Signed-off-by dreispt
@OCA-git-bot
Copy link
Contributor

@dreispt your merge command was aborted due to failed check(s), which you can inspect on this commit of 14.0-ocabot-merge-pr-1267-by-dreispt-bump-minor.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jun 23, 2024
@github-actions github-actions bot closed this Jul 28, 2024
@JoanSForgeFlow
Copy link
Author

@dreispt Is it possible to reopoen and merge? I think it is a needed fix for the module.

Thank you

@dreispt dreispt reopened this Jul 30, 2024
@dreispt
Copy link
Sponsor Member

dreispt commented Jul 30, 2024

Sure, can you rebase please?

@JoanSForgeFlow JoanSForgeFlow force-pushed the 14.0-fix-hr_employee_birthay_mail-res_users branch from b227b16 to c6a8be9 Compare July 30, 2024 11:33
@JoanSForgeFlow
Copy link
Author

@dreispt Yes, of course. Done!

@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Aug 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants