[18.0][MIG] hr_holidays_public: Migration to 18.0 #147
Conversation
xaviedoanhduy
force-pushed
the
18.0-mig-hr_holidays_public
branch
2 times, most recently
from
ad805ca to
3592736
Compare
xaviedoanhduy
force-pushed
the
18.0-mig-hr_holidays_public
branch
from
3592736 to
061cd2f
Compare
|
/ocabot migration hr_holidays_public |
Add correct calculation of holidays in hr_public_holidays, instead of hr_holidays_compute_days. Remove dependancy of contracts. Add unlink at onchnage of public holiday lines. Update code. Fix flake. Update code, add calculation in hours, update views. Update flake. Update calendar creation with no attendances, otherwise default values were set. Remove config of show days/hours. Update flake. Update readme. Rename module. Updated holiday reports. Update klake and pylint. Update flaket. Update hr_holidays_views.xml Add readonly to show_full_days. Update code according with comments. Increase coverage. update flake8.
Hours part will be in module hr_holidays_hour.
Reduce to the minimum the footprint of this module, adding only public holidays as leaves in a transparent way by other modules.
This has been totally reworked for decoupling parts, not depending now on hr_holidays_public, and making transparent its use for compatibility with other modules.
Currently translated at 52.5% (21 of 40 strings) Translation: hr-11.0/hr-11.0-hr_holidays_public Translate-URL: https://translation.odoo-community.org/projects/hr-11-0/hr-11-0-hr_holidays_public/de/
Currently translated at 55.0% (22 of 40 strings) Translation: hr-12.0/hr-12.0-hr_holidays_public Translate-URL: https://translation.odoo-community.org/projects/hr-12-0/hr-12-0-hr_holidays_public/es/
Currently translated at 95.0% (38 of 40 strings) Translation: hr-12.0/hr-12.0-hr_holidays_public Translate-URL: https://translation.odoo-community.org/projects/hr-12-0/hr-12-0-hr_holidays_public/fr/
Currently translated at 92.5% (37 of 40 strings) Translation: hr-12.0/hr-12.0-hr_holidays_public Translate-URL: https://translation.odoo-community.org/projects/hr-12-0/hr-12-0-hr_holidays_public/es/
Currently translated at 92.5% (37 of 40 strings) Translation: hr-12.0/hr-12.0-hr_holidays_public Translate-URL: https://translation.odoo-community.org/projects/hr-12-0/hr-12-0-hr_holidays_public/de/
Currently translated at 100.0% (40 of 40 strings) Translation: hr-12.0/hr-12.0-hr_holidays_public Translate-URL: https://translation.odoo-community.org/projects/hr-12-0/hr-12-0-hr_holidays_public/es/
…idays are defined for each year
Currently translated at 45.0% (18 of 40 strings) Translation: hr-12.0/hr-12.0-hr_holidays_public Translate-URL: https://translation.odoo-community.org/projects/hr-12-0/hr-12-0-hr_holidays_public/pt_BR/
- Include context keys for avoiding mail operations overhead.
Currently translated at 100.0% (40 of 40 strings) Translation: hr-holidays-17.0/hr-holidays-17.0-hr_holidays_public Translate-URL: https://translation.odoo-community.org/projects/hr-holidays-17-0/hr-holidays-17-0-hr_holidays_public/it/
…loyee Use case: - Go to Employees to an employee with a different address (country) than our own and with specific public holidays for that country. - Go to the Time-off smart-buttons - We will have to see there the public holidays according to the employee's address TT49839
…hod if the record does not exist yet)
Helper functions to find public holidays did allow to use an hr.employee to filter country and states based on the employee address. Since only the address of the employee was used, modifying the functions to use a res.partner instead of an hr.employee allows more possibilities such as checking public holidays for customers and suppliers.
xaviedoanhduy
force-pushed
the
18.0-mig-hr_holidays_public
branch
from
242057b to
8117402
Compare
|
hi @victoralmau, thanks for the suggestions |
|
This PR has the |
|
We talk here about splitting the generic feature into a new module, and then provide an extension for HR: And what about the feature that Odoo has about the same concept? |
xaviedoanhduy
force-pushed
the
18.0-mig-hr_holidays_public
branch
from
8117402 to
4c9c51b
Compare
|
Please cherry-pick #156 + #157 to commit history. My colleague's comment is still pending #147 (comment). |
|
@pedrobaeza I wish I had more time to dive into this topic because the model exists since a few versions, but AFAICT standard public holidays still don't have the same flexibility as we have in the OCA module. I guess a first step to converge both modules would be to have "rules" allowing creation of resource calendar leaves from the OCA holidays public. Still, IMO would be nice to split the module to remove dependency on HR, and provide extension module for HR. |
|
Yes, we have talked today in my team about the Odoo core feature and it seems less complete than current one, and switching doesn't worth. |
|
hi i did some work:
let me know guys if this matches with your expectations |
|
Now that |
Change on version 18.0
number_of_hours_displayfields has been removed in [IMP] hr_holidays: clean leave duration fields odoo/odoo#156117On the occasion
OCA - port