Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0][MIG] delivery_carrier_multi_zip: Migration to 14.0 #528

Closed
wants to merge 4 commits into from

Conversation

rizzel
Copy link

@rizzel rizzel commented Aug 26, 2022

Migration to 14.0.

Nothing had to be changed. The things I added are:

  • added a default_order to the tree view
  • added a German translation

If some of the commits should be squashed just tell me.

@pedrobaeza pedrobaeza changed the title 14.0 mig delivery carrier multi zip [14.0][MIG] delivery_carrier_multi_zip: Migration to 14.0 Aug 26, 2022
@pedrobaeza
Copy link
Member

Thanks for going on with this! Please check the tests to see why they are red. You can squash together the first 4 commits, and extract in a separate one the improvements.

@rizzel
Copy link
Author

rizzel commented Aug 26, 2022

I will do the rebase, however the linked tests fail on the delivery_carrier_location module - which I did not touch :(

How best to proceed here?

@rizzel rizzel force-pushed the 14.0-mig-delivery_carrier_multi_zip branch from 2d0f9fe to d8a0a83 Compare August 26, 2022 16:19
@rizzel
Copy link
Author

rizzel commented Aug 26, 2022

It seems delivery_carrier_location also introduced a field zip_ids in the delivery.carrier module. I will have a look at that module and see what that does and if both can coexist somehow. Or the functionality is implemented by the other module somehow.

@rizzel rizzel force-pushed the 14.0-mig-delivery_carrier_multi_zip branch from d8a0a83 to db7aa54 Compare August 26, 2022 23:41
@rizzel rizzel force-pushed the 14.0-mig-delivery_carrier_multi_zip branch from db7aa54 to c0d2d76 Compare August 26, 2022 23:47
@rizzel
Copy link
Author

rizzel commented Aug 29, 2022

I think I'm done. If you need anything else changed just tell me.

@rousseldenis
Copy link
Contributor

/ocabot migration delivery_carrier_multi_zip

@rousseldenis
Copy link
Contributor

@rizzel @pedrobaeza It seems this is weird. First commit does not look like in v13 branch.

@victoralmau
Copy link
Member

Superseed by #539

@pedrobaeza pedrobaeza closed this Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants