Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][MIG] account_banking_pain_base #974

Closed
wants to merge 257 commits into from

Conversation

wpichler
Copy link
Contributor

@wpichler wpichler commented Oct 25, 2022

@wpichler
Copy link
Contributor Author

This will need these cahnges:
15661a2

@Reyes4711-S73
Copy link
Contributor

@wpichler You added also the modules banking sepa direct debit and account_banking_mandate.
This modules must be migrated in other PR separeted, so please, remove it.
@pedrobaeza

pedrobaeza and others added 25 commits January 27, 2023 10:36
The restriction rule Banking Mandate multi-company, gives an error when editing a partner bank account from a company A when that account has created a mandate from another company B. So it is impossible to create a mandate for each company without disabling the rule.
Solution: Uncheck the rule writte in Banking Mandate multi-company. But i'm not sure this is correct.
* Short headers
* Bump version numbers
* es translations
* Add creditor identifier field to report mandate.
* Translate.
* Split basic and sepa mandate
* Use api.multi instead
* Make format field required
Port almost all modules to v10

* Update to EPC Rulebook v9.2 that start to apply on 2016-11-20 (bug OCA#300)
…ovided

Using same method as in upstream, mandate is filled on invoice creation if no
one is provided. This way, we don't need to install account_banking_mandate_sale
if we don't want to handle several mandates at sales level.
…date + Add valid_mandate field and fix onchange

(cherry picked from commit 25d2e4d)
* Fix tests due to upstream change

  Odoo has added a constraint for avoiding a company currency change if there
  are move lines, making these tests to fail, as the currency is changed to EUR.

  With this commit, we create a new company with EUR currency for avoiding the
  problem.

  This commit also changes account_banking_mandate for not duplicating mandate
  number, as it was detected during the test creation.

  Similar to 1f8e345
* Avoid errors in tests when run with other modules
* More adaptations to make tests to work properly

  All these problems comes from using demo data.
Currently translated at 100,0% (82 of 82 strings)

Translation: bank-payment-11.0/bank-payment-11.0-account_banking_mandate
Translate-URL: https://translation.odoo-community.org/projects/bank-payment-11-0/bank-payment-11-0-account_banking_mandate/es/
Currently translated at 68,3% (56 of 82 strings)

Translation: bank-payment-11.0/bank-payment-11.0-account_banking_mandate
Translate-URL: https://translation.odoo-community.org/projects/bank-payment-11-0/bank-payment-11-0-account_banking_mandate/ca/
So multi-company environment won't work correctly.
@wpichler wpichler force-pushed the 16.0-mig-account_banking_pain_base branch 2 times, most recently from 6097ab3 to 182ce00 Compare January 27, 2023 10:14
@wpichler
Copy link
Contributor Author

@wpichler maybe this is useful for you in this case: https://github.com/OCA/maintainer-tools/wiki/Use-temporary-reference%28s%29-to-another-pull-request%28s%29

Thank you - that was exact what i was looking for - works like a charm

@pedrobaeza pedrobaeza changed the title 16.0 mig account banking pain base [16.0][MIG] account_banking_pain_base Feb 1, 2023
@pedrobaeza
Copy link
Member

/ocabot migration account_banking_pain_base

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Feb 1, 2023
@OCA-git-bot OCA-git-bot mentioned this pull request Feb 1, 2023
14 tasks
@Reyes4711-S73
Copy link
Contributor

@OCA/banking-maintainers There are some PR depending on this and others, Could you review and merge the maximum as possible?

@hildickethan
Copy link
Member

[DEL] Removed modules which do not belong to this PR
this commit is unnecessary if you remove the commits of those other modules from the history, which is better since theyre entirely useless here

[IMP] Precommit updates
this commit should also disappear once the other module commits are gone and squashed into [IMP] account_banking_pain_base: pre-commit stuff

Copy link
Member

@hildickethan hildickethan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

migration itself LGTM, just need the commit cleanup

Copy link

@AnizR AnizR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM. But can you apply the request concerning commits cleanup?

[REF] account_banking_pain_base: Adapt module to native payment refactoring

[ADD] Added AT to list of supported countries for SEPA. Fixes OCA#1002

[DEL] Removed modules which do not belong to this PR

[IMP] Precommit updates
@wpichler wpichler force-pushed the 16.0-mig-account_banking_pain_base branch from 182ce00 to 29b53b2 Compare February 18, 2023 17:07
@astirpe
Copy link
Member

astirpe commented Mar 8, 2023

@wpichler module account_payment_order was merged into V16. Could you please remove test-requirements.txt and rebase this PR?

@pedrobaeza
Copy link
Member

A commit squashing and to include this commits is needed: 15661a2

@StephaneMangin
Copy link

cc @wpichler You can remove this dependency #972
Superseeded by #1056 and merged.

@StephaneMangin
Copy link

cc @wpichler Do you need help for this PR ? to push forward

@StephaneMangin
Copy link

cc @wpichler Any update about this PR ?

@manuelcalerosolis

This comment was marked as off-topic.

@rousseldenis
Copy link
Contributor

@wpichler

@pedrobaeza
Copy link
Member

pedrobaeza commented May 27, 2023

The commit history of this one is totally mangled, with more than 250 commits where there's actually less than a hundred, so I have started the commit history fetching from the scratch. As there's no significant changes on the module itself either, and the migration commit of this one is not correct, I'm totally discarding it in favor of #1087, so closing this one and merging the other for finally unblocking this.

@pedrobaeza pedrobaeza closed this May 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.