[MIG] account_banking_sepa_credit_transfer: Migration to 16.0 #1037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Small API changes * Updated two additional imports to new API * A payment mode type needs a suitable bank type
…tion of the SEPA XML file is now really working Update views to 7.0-style Better error handling when Bank account in missing on the invoice.
…tures available without pulling bank statement features - introduce account_banking_payment_export module with all features from account_banking_payment that do not involve changing the payment order workflow or depend on bank statement changes - account_banking_payment_export does not depend on account_banking - account_banking_payment is consequently stripped of above features - account_banking_sepa_credit_transfer depend on account_banking_payment_export and is compatible with the default payment order workflow - clarified comment about workflow in account_banking_sepa_credit_transfer - avoid generating invalid sepa credit transfer files when bank accounts have no BIC
…e instead of tomorrow
…r things:
* Add support for pain.001.001.05 Fix dependencies (I need the field "payment_order_type" which is in account_banking_payment) Only use ASCII characters in the XML file (that's how banks use XML !) Use the payment order reference as the Message Identification of the XML file. Use the payment line sequence as the "End to End Identification" Remove the Instruction Identification ('InstrId') because it is not a required field (only the End to End identification is required) Rename variables in the function create_sepa() to include the number of each field as used in the EPC guidelines Reduce the number of flake8 warnings Make code more modular : - self.pool.get('banking.export.sepa').create() has a _prepare fonction - most of the content of the XML file can be inherited via _prepare_field()
* Update strings. Update FR translation.
* fields.date.context_today doesn't work with datetime => we now use the native field create_date Coding style improvements.
* Add logo
* Better prototype for the _prepare_field function. Update help message, POT file and FR translation. * Revert the dependancy to account_banking_payment_export (the field payment_order_type on payment.mode.type has a default value of "payment" anyway). * Akretion-Noviat code sprint dated 2013-11-21: - add module account_banking_pain_base - add support for initiating party identification, priority and structured remittance info in XML file - the requested execution date now uses the fields date_prefered and date_scheduled (the field of the wizard has been removed) - the 'convert to ascii' feature is now an option of the payment mode (enabled by default) - set 'communication' field of payment.line to 140 chars and hide field 'communicatio n2' * FIX label : Customer (which is wrong, it is most of the time a Supplier !)-> Creditor More PEP8 stuff.
* Start code factoring between SCT and SDD. * More code factoring between SCT and SDD As a consequence, we now have support for structured remittance info in SDD. * The requested collection date now uses the fields date_prefered and date_scheduled of payment.order, instead of the field in the SDD wizard. * Mutualize more code between SCT and SDD. * Replace unallowed ascii caracters by '-' Update some error messages Update translation files and FR translation Include sepa_export in gen_args Factorize more code between SDD and SCT Fix view of payment lines The modules account_banking_pain_base and account_banking_sepa_* are now fully PEP8 compliant * For SCT, if BIC is not provided, we should not put the 'Creditor Agent' block at all, according to EPC guidelines (on this point, it is different from the Direct Debit !) * Add demo data * Add missing utf-8 header Update state field on SEPA file objects and display it in tree+form views. Migrate form views to version 7.0 and simplify them.
Since the bank is optional on bank accounts and the BIC can be set on the bank account if there is no bank, we allow the system to get the BIC from the bank account in case it is not on the bank. We give priority to the BIC indicated on the bank, keeping the same behaviour with existing data where the bank BIC is available.
Fix an important regression in account_banking_sepa_direct_debit: "Date of Last Debit" was not set any more Proper write of date_done with account_banking_payment_export is installed without account_banking_payment_transfer Add post-install script for date_sent on payment.order
Sometimes sepa file could have been detached from the corresponding payment order.
…ion numbers + es translations
Currently translated at 70.5% (12 of 17 strings) Translation: bank-payment-14.0/bank-payment-14.0-account_banking_sepa_credit_transfer Translate-URL: https://translation.odoo-community.org/projects/bank-payment-14-0/bank-payment-14-0-account_banking_sepa_credit_transfer/fr_FR/
Fix bug in account_banking_mandate when a res.partner.bank is not attached to a particular company (company_id is NOT required on res.partner.bank)
sepa_credit_transfer: bank_account_required back to True Partial revert of the breakage of PR OCA#875
Currently translated at 100.0% (17 of 17 strings) Translation: bank-payment-14.0/bank-payment-14.0-account_banking_sepa_credit_transfer Translate-URL: https://translation.odoo-community.org/projects/bank-payment-14-0/bank-payment-14-0-account_banking_sepa_credit_transfer/sv/
Currently translated at 28.5% (4 of 14 strings) Translation: bank-payment-14.0/bank-payment-14.0-account_banking_sepa_credit_transfer Translate-URL: https://translation.odoo-community.org/projects/bank-payment-14-0/bank-payment-14-0-account_banking_sepa_credit_transfer/pt_BR/
…to pain.001.001.03
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: bank-payment-14.0/bank-payment-14.0-account_banking_sepa_credit_transfer Translate-URL: https://translation.odoo-community.org/projects/bank-payment-14-0/bank-payment-14-0-account_banking_sepa_credit_transfer/
Currently translated at 100.0% (17 of 17 strings) Translation: bank-payment-14.0/bank-payment-14.0-account_banking_sepa_credit_transfer Translate-URL: https://translation.odoo-community.org/projects/bank-payment-14-0/bank-payment-14-0-account_banking_sepa_credit_transfer/es_AR/
…yment refactoring Notables changes: - InstrId and EndToEndId tags are now filled with the journal entry ID, as there's no bank payment line identifier.
AnizR
force-pushed
the
16.0-mig-account_banking_sepa_credit_transfer
branch
5 times, most recently
from
597dca0 to
3e3a95f
Compare
AnizR
force-pushed
the
16.0-mig-account_banking_sepa_credit_transfer
branch
from
3e3a95f to
343c66e
Compare
|
This should include the part of #1031 that corresponds to this. |
Comment on lines
+116
to
+120
| # cls.main_company.write({ | ||
| # 'account_journal_payment_debit_account_id': cls.payment_debit_account_id.id, | ||
| # 'account_journal_payment_credit_account_id': cls.payment_credit_account_id.id | ||
| # }) | ||
|
|
There was a problem hiding this comment.
to remove if not necessary
From what I can see this is included in the migration commit, but this being a migration from 14 -> 16 when 15 is merged seems a bit off when it comes to commit history, as if it was done from 15 that commit would be there We have 2 PRs now for the same module, I think this one is unnecessary with the current state of #990 🤔 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migration of module account_banking_sepa_credit_transfer
Depends #974 #1036
I know that there is pr #990 but imo I couldn't just suggest changes because there were too important.
e.g.
bank-payment/account_banking_sepa_credit_transfer/models/account_payment_order.py
Line 81 in 6edf837