Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add docs for new NuGet warning NU3043 #3339
add docs for new NuGet warning NU3043 #3339
Changes from 2 commits
44f00ee
7dc5a33
1a1b283
bfe5eaa
af2d843
eb498dd
04daf90
a044c0d
3f40abd
dfd4fc2
693a608
4536bb2
df9ccab
9ea202d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
opinionated: when I view the preview for this page, this note block being such a contrasting colour from the rest of the page, it really steals my attention. But, I don't feel like "this will be an error in a future version" to be important enough to warrant taking away my attention from other parts of the doc.
Funnily enough, the docs contribution guide says this: https://learn.microsoft.com/en-au/contribute/content/markdown-reference#alerts-note-tip-important-caution-warning
So, I feel like it has the opposite problem, rather than skipping it, I find it hard to look away.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the feedback. I removed the NOTE block.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I hope you've already had this conversation with other people, but since .NET 9 is a STS release, this means that a significant number of customers who only use LTS versions will upgrade directly from .NET 8 (no warning) to .NET 10 (apparently going to be an error), which means they won't have an opportunity to see the warning before it starts failing the operation.
This is even more impactful considering that customers might not actually test sign as soon as they upgrade to the .NET 10 SDK, similar to how we don't real sign in builds other than the official build. At least something affecting restore will be encountered on the first restore after the upgrade. Honestly, I can imagine some pipelines might not sign until just before pushing packages, which might mean that the command will be a release blocker, when there was "no" prior warning. It's entirely possible that customers will run sign in CI pipelines and never read the warning in the logs, but at least we'll be able to say that there was a warning in an LTS version of .NET that they could have seen if they read the logs.
So, it might be kinder to make this an error in .NET 11, rather than .NET 10.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great feedback. It makes sense to me. I will update the spec with this decision to promote this warning to an error around .NET 11 timeframe. https://github.com/NuGet/Client.Engineering/pull/3015
EDIT: Based on our internal conversation, we are leaning towards promoting the warning to an error in the .NET 10 timeframe. I have updated this PR again and closed the draft PR I created to update the spec.