-
Notifications
You must be signed in to change notification settings - Fork 481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add docs for new NuGet warning NU3043 #3339
base: main
Are you sure you want to change the base?
Conversation
Learn Build status updates of commit 44f00ee: 💡 Validation status: suggestions
docs/reference/Errors-and-Warnings.md
For more details, please refer to the build report. Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them. For any questions, please:
|
Learn Build status updates of commit 7dc5a33: 💡 Validation status: suggestions
docs/reference/Errors-and-Warnings.md
For more details, please refer to the build report. Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them. For any questions, please:
|
I disabled auto merge, because I want multiple people to have the opportunity to review and provide comments before it gets merged, not just the first person to review it 1 minute after the PR was created. |
`dotnet nuget sign command` - Invalid value for `--certificate-fingerprint` option. The value must be a SHA-256, SHA-384, or SHA-512 certificate fingerprint (in hexadecimal). | ||
|
||
`NuGet.exe sign command` - Invalid value for `CertificateFingerprint` option. The value must be a SHA-256, SHA-384, or SHA-512 certificate fingerprint (in hexadecimal). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not using the same formatting/style that most other warning pages use.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated the docs in the latest commit. Please take a look and let me know if it looks good.
> [!NOTE] | ||
> This warning will be promoted to an error around the .NET 10 timeframe. | ||
|
||
## Solution |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All other warning pages has an ## Issue
header, that explains why the warning exists, before the solution section
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great catch. Fixed in the latest commit.
Learn Build status updates of commit 1a1b283: 💡 Validation status: suggestions
docs/reference/Errors-and-Warnings.md
For more details, please refer to the build report. Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them. For any questions, please:
|
Learn Build status updates of commit bfe5eaa: 💡 Validation status: suggestions
docs/reference/Errors-and-Warnings.md
For more details, please refer to the build report. Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them. For any questions, please:
|
Co-authored-by: Andy Zivkovic <[email protected]>
Learn Build status updates of commit af2d843: 💡 Validation status: suggestions
docs/reference/Errors-and-Warnings.md
For more details, please refer to the build report. Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them. For any questions, please:
|
…ocs.microsoft.com-nuget into dev-kmps-add-nu3043-docs
Learn Build status updates of commit 04daf90: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
Learn Build status updates of commit a044c0d: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
Tracking: https://github.com/NuGet/Client.Engineering/issues/2994
Starting with .NET 9 Preview 7 and NuGet.exe 6.12, NuGet sign commands will raise a
NU3043
warning if an invalid value or SHA-1 hash is passed for the certificate fingerprint option. The value must be a SHA-256, SHA-384, or SHA-512 certificate fingerprint (in hexadecimal).