Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[24.05] Discord backports #348120

Open
wants to merge 2 commits into
base: release-24.05
Choose a base branch
from

Conversation

Artturin
Copy link
Member

@Artturin Artturin commented Oct 12, 2024

(cherry picked from commit 1c9844e)

Included hostPlatform in the conditional for future backports

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

jfvillablanca and others added 2 commits October 12, 2024 20:35
(cherry picked from commit 1c9844e)

Included `hostPlatform` in the conditional for future backports
Signed-off-by: Sefa Eyeoglu <[email protected]>
(cherry picked from commit a765e43)
@Artturin Artturin changed the title [24.05] discord: 0.0.67 -> 0.0.70 [24.05] Discord backports Oct 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants