nixos/vpp: init module #347797
Draft
nixos/vpp: init module #347797
+669
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romner-set
force-pushed
the
vpp-service
branch
2 times, most recently
from
3cad8ad
to
e0dc519
Compare
romner-set
force-pushed
the
vpp-service
branch
2 times, most recently
from
8a3d670
to
35dd879
Compare
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/4668 |
romner-set
force-pushed
the
vpp-service
branch
from
35dd879
to
b38f26f
Compare
13 tasks
romner-set
force-pushed
the
vpp-service
branch
from
b38f26f
to
5d9f832
Compare
romner-set
force-pushed
the
vpp-service
branch
from
5d9f832
to
ddd6d23
Compare
romner-set
force-pushed
the
vpp-service
branch
from
ddd6d23
to
ef5b42f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Module & associated tests for #346281. Currently includes the commits from that PR for easier testing (and to prevent CI/CD errors), but I'll rebase this PR on master once (if?) the package gets merged separately.
Includes an RFC42 (mostly, none of the options are documented as of yet)
configoption using a custom parser based on znc's. The test is pretty basic and verifies routing functionality between 2 hosts with VPP acting as the router.TODO:
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.