Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vpp: init at 24.06 #346281

Merged
merged 2 commits into from
Oct 12, 2024
Merged

vpp: init at 24.06 #346281

merged 2 commits into from
Oct 12, 2024

Conversation

romner-set
Copy link
Contributor

@romner-set romner-set commented Oct 4, 2024

Description of changes

VPP is a high-performance userland network stack for routing/switching on general purpose computers.

Supersedes #290529 & #256601, module & tests will be added later in a separate PR (#347797). Basic multithread routing functionality w/ DPDK was tested on an Intel X520-DA2 NIC.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/4668

@romner-set romner-set mentioned this pull request Oct 11, 2024
13 tasks
pkgs/by-name/vp/vpp/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/vp/vpp/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/vp/vpp/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/vp/vpp/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/vp/vpp/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/vp/vpp/package.nix Show resolved Hide resolved
pkgs/by-name/vp/vpp/package.nix Outdated Show resolved Hide resolved
Copy link
Member

@markuskowa markuskowa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now. Just waiting for the CI to build everything.

@markuskowa markuskowa merged commit fbfea21 into NixOS:master Oct 12, 2024
28 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants