tinygo: 0.30.0 -> 0.31.1 #262346
tinygo: 0.30.0 -> 0.31.1 #262346
Conversation
aykevl
force-pushed
the
tinygo-v0.31.0
branch
from
0a044b7 to
b17db1d
Compare
|
I've updated the package to the v0.31.1, which is our last release. It is now ready for review. |
There was a problem hiding this comment.
Could you cherry pick #286984?
There was a problem hiding this comment.
Yes, thank you! I was able to remove the buildid workaround patch with your patch.
If I understand correctly, all it does is make sure the binary has a valid build ID? That is, it make sure the build ID isn't stripped?
There was a problem hiding this comment.
If I understand correctly, all it does is make sure the binary has a valid build ID? That is, it make sure the build ID isn't stripped?
Yes, build id is set to empty value by default with #276685.
|
Result of 1 package built:
|
I've dropped a number of patches that were unnecessary after some improvements in TinyGo to make it work better with in a Nix environment.
This looks cleaner to me, although I don't know the usual Nix convention for this sort of thing.
We need our own build because we modify the build flags in a particular way. Also, we've only tested wasi-libc at the version pinned in the submodule, later versions may or may not work correctly.
Oops, fixed now. |
Description of changes
Update to version 0.31.0, and simplify the package quite a bit.
Due to changes since 0.30.0, many of the patches can now be dropped.
One functional change is the removal of the wasi-libc dependency: this PR makes sure we build our own version (which is needed, see the comment for details).
WIP, because 0.31.0 hasn't been released yet. Just wanted to make sure this is available in advance. (There have been a lot of Nix related changes, and I wanted to test them).Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)