Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tinygo: fix typo #257183

Merged
merged 1 commit into from
Apr 4, 2024
Merged

tinygo: fix typo #257183

merged 1 commit into from
Apr 4, 2024

Conversation

TrevorSmale
Copy link
Contributor

@TrevorSmale TrevorSmale commented Sep 25, 2023 •
edited
Loading

Description of changes

[- See diff.](tinygo: fix typo)

@NixOSInfra NixOSInfra added the 12. first-time contribution This PR is the author's first one; please be gentle! label Sep 25, 2023
@ofborg ofborg bot requested review from muscaln and Madouura September 25, 2023 04:40
pbsds
pbsds approved these changes Sep 25, 2023
View reviewed changes
Copy link
Member

@pbsds pbsds left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, should cause no conflict, just a tiny thing to follow nixpkgs convention

pbsds
pbsds previously requested changes Sep 25, 2023
View reviewed changes
pkgs/development/compilers/tinygo/default.nix Show resolved Hide resolved
@pbsds pbsds self-requested a review September 25, 2023 18:14
wolfgangwalther
wolfgangwalther approved these changes Apr 3, 2024
View reviewed changes
Copy link
Contributor

@wolfgangwalther wolfgangwalther left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose a committer could just squash and fix the commit message accordingly.

@pbsds
Copy link
Member

pbsds commented Apr 3, 2024 •
edited
Loading

Thanks for the bump, i have since become a committer.

waiting for eval

@pbsds pbsds dismissed their stale review April 3, 2024 21:56

fixed

@kirillrdy
Copy link
Member

Thanks for the bump, i have since become a committer.

waiting for eval

i am the author of the spelling mistake :-)

@kirillrdy kirillrdy changed the title Update default.nix tinygo: fix typo Apr 3, 2024
@kirillrdy
Copy link
Member

I've updated PR title to match commit message

pbsds
pbsds approved these changes Apr 4, 2024
View reviewed changes
Copy link
Member

@pbsds pbsds left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now i am confused. Tinygo fails on all platforms on hydra likely since #262346:

They all fail fetching the source, across two version bumps.

ofborg aarch64-linux passes on this PR, but not x86_64-linux, due to a build failure. The installPhase warnings on aarch64-linux indicates that it only passes due to a what i assume is a set +e somewhere.

This PR should be good to merge however, since tinygo-bootstrap-tools at least seems to build, but tinygo really could use a look over.

@kirillrdy
Copy link
Member

Result of nixpkgs-review pr 257183 run on x86_64-linux 1

1 package built:
  • tinygo

@kirillrdy kirillrdy merged commit 5d1a8fc into NixOS:master Apr 4, 2024
25 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wolfgangwalther wolfgangwalther wolfgangwalther approved these changes

@pbsds pbsds pbsds approved these changes

@muscaln muscaln Awaiting requested review from muscaln

@Madouura Madouura Awaiting requested review from Madouura

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@TrevorSmale @pbsds @kirillrdy @wolfgangwalther @NixOSInfra