Vendor SPSDK dependency #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 1, 2024
robin-nitrokey
force-pushed
the
spsdk
branch
2 times, most recently
from
826f271 to
7868371
Compare
daringer
approved these changes
Aug 7, 2024
This commit is extracted from: Nitrokey/pynitrokey#519 I’ve further reduced the included code so that we can get rid of even more dependencies: We only need crcmod, cryptography and libusbsio. We now also pass strict mypy checks on all imported modules (except for the libusbsio imports). Co-authored-by: Sosthène Guédon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is extracted from: Nitrokey/pynitrokey#519
I’ve further reduced the included code so that we can get rid of even more dependencies: We only need crcmod, cryptography and libusbsio. We now also pass strict mypy checks on all imported modules (except for the libusbsio imports).
To do: