Slotted array search and insert optimizations #370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukaszRozmej
reviewed
Jul 4, 2024
| @@ -62,7 +62,8 @@ public bool TrySet(in NibblePath key, ReadOnlySpan<byte> data) | |||
|
|
|||
| private bool TrySetImpl(ushort hash, byte preamble, in NibblePath trimmed, ReadOnlySpan<byte> data) | |||
| { | |||
| if (TryGetImpl(trimmed, hash, preamble, out var existingData, out var index)) | |||
| var index = TryGetImpl(trimmed, hash, preamble, out var existingData); | |||
There was a problem hiding this comment.
maybe better that it would return a bool and index would be out param?
There was a problem hiding this comment.
This was done before. As #369 showed it cuts off 40 bytes from 800 byte long method without impact on the call sites that need to compare it anyway. Follows IndexOf and others low lvl method in BCL.
Scooletz
added
🐌 performance
Minimum allowed line rate is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to address the crux of the db performance issues,
SlottedArraycomponent that is visible in both, inserts and gets from the database. It does it in the following way:TryGetImplchanged from bool returning to index returning results in shorter code (~40 bytes)IsDeletedcheckis not needed and can be removed saving one bool check and reducing the size furtherMarkAsDeleted, when marking the entry as deleted changes its hash (to simple ~hash) so that it will no longer hit the search. See theSet_And_Deletebenchmark below. This is 💥 for both sets and gets as they use this function heavily. The gains are tremendous.Benchmarks
Selected benchmarks used to check the speed.
Before
After