Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SlottedArray faster search #369

Closed
wants to merge 8 commits into from
Closed

SlottedArray faster search #369

wants to merge 8 commits into from

Conversation

Scooletz
Copy link
Contributor

@Scooletz Scooletz commented Jul 2, 2024 •
edited
Loading

This PR augments SlottedArray to make it faster so that the data application is faster as well.

  1. 4c0a052 - TryGetImpl changed from bool returning to index returning results in shorter code, from 809 to 777
  2. 70e765d - removed not needed IsDeleted check ; Total bytes of code 738

@Scooletz Scooletz mentioned this pull request Jul 2, 2024
Closed
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 3, 2024

Code Coverage

Package Line Rate Branch Rate Health
Paprika 85% 80% ✔
Summary 85% (4217 / 4955) 80% (1356 / 1696) ✔

Minimum allowed line rate is 75%

@Scooletz
Copy link
Contributor Author

Scooletz commented Jul 4, 2024

Will be replaced by #370 and a custom augmentation of the search

@Scooletz Scooletz added the 🐌 performance Perofrmance related issue label Jul 4, 2024
@Scooletz Scooletz closed this Jul 4, 2024
@Scooletz Scooletz deleted the slotted-array-faster-search-2 branch July 4, 2024 08:06
@Scooletz Scooletz mentioned this pull request Jul 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
🐌 performance Perofrmance related issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Scooletz