Set parameters for running flow instead of any imported #1691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the issue where parameters for multiple imported flows are displayed instead of the running one when multple flows are in the same file with parameters. Also: 1. Change to use Exception as bare except is bad practice / fails flake8. 2. Switch to editable/develop install so any code changes would be effective without reinstalling. Much faster to iterate changes.
saikonen
previously approved these changes
Jan 18, 2024
saikonen
reviewed
Jan 18, 2024
|
Testing[600] @ e16bf74 |
|
|
savingoyal
approved these changes
Jan 18, 2024
|
Testing[600] @ e16bf74 had 2 FAILUREs. |
|
Testing[600] @ cd13ef0 had 5 FAILUREs. |
emattia
pushed a commit
to emattia/metaflow
that referenced
this pull request
Jan 23, 2024
* Set parameters for running flow instead of any imported This fixes the issue where parameters for multiple imported flows are displayed instead of the running one when multple flows are in the same file with parameters. Also: 1. Change to use Exception as bare except is bad practice / fails flake8. 2. Switch to editable/develop install so any code changes would be effective without reinstalling. Much faster to iterate changes. * suggested changes * restore except blocks --------- Co-authored-by: Max Zheng <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested changes on top of the work of @maxzheng on #1653