Set parameters for running flow instead of any imported #1653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the issue where parameters for multiple imported flows are displayed instead of the running one when multple flows are in the same file with parameters. Also: 1. Change to use Exception as bare except is bad practice / fails flake8. 2. Switch to editable/develop install so any code changes would be effective without reinstalling. Much faster to iterate changes.
madhur-ob
reviewed
Jan 15, 2024
| # This must be set before calling cli.main() below (or specifically, add_custom_parameters) | ||
| parameters.parameters = [ | ||
| getattr(self, a) | ||
| for a in dir(self) |
There was a problem hiding this comment.
There's already a function known as _get_parameters, we can probably re-use that instead?
There was a problem hiding this comment.
something like: parameters.parameters = [p for _, p in self._get_parameters()]
madhur-ob
approved these changes
Jan 15, 2024
There was a problem hiding this comment.
Maybe @savingoyal can comment on changes to test_runner and tox.ini, LGTM otherwise...
Will prefer re-using self._get_parameters too...
saikonen
requested changes
Jan 16, 2024
| @@ -1,2 +1,5 @@ | |||
| [metadata] | |||
| license_files = LICENSE | |||
|
|
|||
| [flake8] | |||
| max-line-length = 120 | |||
There was a problem hiding this comment.
seems like an unrelated change to the PR. We're also not using flake8 currently
| @@ -5,7 +5,7 @@ set -o errexit -o nounset -o pipefail | |||
| install_deps() { | |||
| for version in 2 3; | |||
| do | |||
| python$version -m pip install . | |||
| python$version -m pip install -e . | |||
There was a problem hiding this comment.
is it necessary to change to an editable install for this PR?
| @@ -3,4 +3,4 @@ | |||
| [testenv] | |||
| allowlist_externals = ./test_runner | |||
| commands = ./test_runner | |||
|
|
|||
| usedevelop = True | |||
|
closing as this was superseded by #1691 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issue where parameters for multiple imported flows are displayed instead of the running one when multiple flows are in the same file with parameters.
Also:
Note: I didn't add a test for this as this feature is already tested by many existing tests and they worked fine with this change, but happy to add one specifically for the mentioned issue if desired.