Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add write timeout configuration (backwards compatible) #589

Merged
merged 5 commits into from
Aug 21, 2023
Merged

Add write timeout configuration (backwards compatible) #589

merged 5 commits into from
Aug 21, 2023

Commits on Aug 15, 2023

  1. Revert "Revert "Accept write_timeout configuration, and supply it alo… 

    …ng to savoy (NetSweet#587)""

This reverts commit f43ead8.
    @nevinera
    nevinera committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    4a2f2f5 View commit details
    Browse the repository at this point in the history

  2. Extract savon_params as a variable for manipulation

    @nevinera
    nevinera committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    44b64c9 View commit details
    Browse the repository at this point in the history

  3. extract Configuration#savon_params and test it directly

    @nevinera
    nevinera committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    79f8ecf View commit details
    Browse the repository at this point in the history

  4. Only supply and allow setting write_timeout when Savon supports it

    @nevinera
    nevinera committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    26fb143 View commit details
    Browse the repository at this point in the history

  5. These tests need to execute against both old and new versions of Savon 

    Which means we can't actually instantiate the connection when
_pretending_ to have a recent savon version, or we'll trick our own
compatibility checks into passing Savon parameters it doesn't support.
    @nevinera
    nevinera committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    e749158 View commit details
    Browse the repository at this point in the history