Add write timeout configuration (backwards compatible) #589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng to savoy (NetSweet#587)"" This reverts commit f43ead8.
Which means we can't actually instantiate the connection when _pretending_ to have a recent savon version, or we'll trick our own compatibility checks into passing Savon parameters it doesn't support.
nevinera
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(revert-revert from #587)
But this time, include a version-check - if Savon is below version 2.13.0, it doesn't accept
write_timeout, and we should also complain (NetSuite::ConfigurationErrorif someone tries to set that option on this gem). And I enabled CI on my fork, instead of running tests locally - I hadn't realized how much of a matrix you were testing against, sorry about that!The
Configuration#connectionmethod got unwieldy during that process (and was a bit undertested), so I extractedConfiguration#savon_paramsas a method, tested it directly, and included contexts exercising the cases whenSavon::VERSIONwas just before and just after thewrite_timeoutfeature was added.