Mdl 58266 master #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the `playbackRates` functionality that was lost in library upgrade (9ea8fa3).
Flickr doesn't like user agent that looks like a bot. Effectively the same reasoning/fix as b8ee31a.
All the group-related settings should be next to each other.
Instead of hard blocking launches with extension scopes, just ignore the unsupported scopes and continue.
- Removed validation on the change edit mode WS. Permission should be handled where the edit button is rendered in order to show or not the button.
- Fixed method user_can_addto to take into account that blocks can also be added to user profile pages
The activity header, which includes things like dates and completion information, was moved out of the page $OUTPUT and into a separate template context variable in 4.0, meaning it was missing from any layout which didn't actively add it back to the page output. This fixes this problem for the embedded layout only by adding support for the activity header in the embedded template.
Modified course format options reading and writing to be able to handle Editor elements by enabling them to split array values into multiple values before inserting into database, and combining multiple values into an array when reading from the database. Modified backup and restore code to use backup_nested_elements, and to interact directly with the database. Co-authored-by: Jason den Dulk <[email protected]> Co-authored-by: Matthew Hilton <[email protected]>
Where obviously safe.
With the notification alert's close button now properly labelled, it is better for Behat to interact on it using its label.
Reverting the addition of a Boostrap tooltip on the alert notification's close button. It introduced a bug where the tooltip remains after dismissing the notification alert. We can manually toggle the state of the tooltip via JS, but I don't think it's worth the effort. The tooltip is meant as an added bonus for sighted users to see what the close button is about.
vuvanhieu143
force-pushed
the
MDL-58266-master
branch
from
b528e27 to
5c26538
Compare
vuvanhieu143
pushed a commit
that referenced
this pull request
Oct 6, 2023
We encountered errors on the plugin check page while upgrading from version 3.11 to 4.3. The plugins marked with the status "To be deleted" have a null value for the $component property, which results in the following error message: "Deprecated: strpos(): Passing null to parameter #1 ($haystack) of type string is deprecated in lib/classes/component.php on line 1056." To avoid this error, we need to set an empty string as the default value for the $component property.
vuvanhieu143
pushed a commit
that referenced
this pull request
Oct 6, 2023
We encountered errors on the plugin check page while upgrading from version 3.11 to 4.3. The plugins marked with the status "To be deleted" have a null value for the $component property, which results in the following error message: "Deprecated: strpos(): Passing null to parameter #1 ($haystack) of type string is deprecated in lib/classes/component.php on line 1056." To avoid this error, we need to set an empty string as the default value for the $component property.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*** PLEASE DO NOT OPEN PULL REQUESTS VIA GITHUB ***
The moodle.git repository at Github is just a mirror of the official repository. We do not accept pull requests at Github.
See CONTRIBUTING.txt guidelines for how to contribute patches for Moodle. Thank you.
--