This repository has been archived by the owner on Feb 1, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 17
Fixed some documentation and fixed support for Python3 #7
Open
abstract-base-method
wants to merge
2
commits into
NWQMC:master
Choose a base branch
from
abstract-base-method:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -9,3 +9,6 @@ | |
#virtualenv | ||
env | ||
sandbox | ||
.venv/ | ||
pywqp.egg-info | ||
.idea/ |
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
from pywqp import pywqp_client | ||
client_instance = pywqp_client.RESTClient() | ||
from pprint import pprint | ||
|
||
|
||
verb = 'get' | ||
host_url = 'http://waterqualitydata.us' | ||
resource_label = 'station' | ||
params = {'countrycode': 'US', 'statecode': 'US:19', 'countycode': 'US:19:015', 'characteristicName': 'pH'} | ||
result = client_instance.request_wqp_data(verb, host_url, resource_label, params, mime_type='text/csv') | ||
|
||
pprint(result.text) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,8 +3,8 @@ | |
import sys | ||
import os.path | ||
import pandas as pd | ||
import StringIO | ||
import wqx_mappings | ||
from io import StringIO | ||
from . import wqx_mappings | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Since this import is for a local package, it should go after the others. In general, our import lists don't at the moment but should follow https://www.python.org/dev/peps/pep-0008/#imports . |
||
import xml.etree.ElementTree as et | ||
|
||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,10 +1,10 @@ | ||
fuzzywuzzy==0.2 | ||
lettuce==0.2.19 | ||
numpy==1.8.1 | ||
pandas==0.14.1 | ||
python-dateutil==2.2 | ||
pytz==2014.4 | ||
lxml==4.4.1 | ||
numpy==1.17.0 | ||
pandas==0.25.0 | ||
python-dateutil==2.8.0 | ||
pytz==2019.2 | ||
requests==2.3.0 | ||
six==1.7.3 | ||
sure==1.2.7 | ||
wsgiref==0.1.2 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,23 +1,25 @@ | ||
import sys | ||
from setuptools import find_packages, setup | ||
|
||
try: | ||
from setuptools import setup | ||
except: | ||
sys.exit('Requires distribute or setuptools') | ||
|
||
from setuptools import find_packages | ||
def requires(): | ||
deps = [] | ||
with open('requirements.txt', 'r') as fil: | ||
for line in fil.readlines(): | ||
deps.append(line.rstrip()) | ||
return deps | ||
|
||
|
||
setup( | ||
name = 'pywqp', | ||
version = '0.1.4-dev', | ||
description = 'Interface to the Water Quality Portal', | ||
long_description = open('README.md').read(), | ||
name='pywqp', | ||
version='0.1.5', | ||
description='Interface to the Water Quality Portal', | ||
long_description=open('README.md').read(), | ||
license='Public Domain', | ||
maintainer='William Blondeau', | ||
maintainer_email='[email protected]', | ||
py_modules=['pywqp'], | ||
packages=find_packages(), | ||
install_requires=['setuptools'], | ||
install_requires=requires(), | ||
url='https://github.com/wblondeau-usgs/pywqp', | ||
test_suite='tests', | ||
) |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would prefer keeping import statements before any other statements in a python module.