Fixed some documentation and fixed support for Python3 #7
Conversation
Signed-off-by: James E. Bell Jr <[email protected]>
Signed-off-by: James E. Bell Jr <[email protected]>
|
The pywqp project lives!! Thanks so much for these changes- they look good, with the exception of the |
|
Out of curiosity, what are you using pywqp for? Any time we can get a good user story about people using the Water Quality Portal, we like to share with project sponsors. |
|
On second look, you kindly deleted .idea files that I committed five years ago. Thanks! |
|
@jkreft-usgs thanks! We are experimenting with the data sets to see if we can improve our analysis pipe corrosion for fire suppression and irrigation systems using these data sets. Currently our only data point is routine physical inspections (which are good and required) but we want to see if this data can help model a more intelligent decision around life cycle of the system. |
|
also I bumped the version to |
|
@mbucknell any chance this could get reviewed soon? I don't mind keeping my fork out there for our users, but I would rather them pull from the NWQMC source |
|
@lemoney yep, various vacations and other distractions have pulled us away, but we will take a look, hopefully this week. |
| @@ -0,0 +1,12 @@ | |||
| from pywqp import pywqp_client | |||
| client_instance = pywqp_client.RESTClient() | |||
| from pprint import pprint | |||
There was a problem hiding this comment.
I would prefer keeping import statements before any other statements in a python module.
| import StringIO | ||
| import wqx_mappings | ||
| from io import StringIO | ||
| from . import wqx_mappings |
There was a problem hiding this comment.
Since this import is for a local package, it should go after the others. In general, our import lists don't at the moment but should follow https://www.python.org/dev/peps/pep-0008/#imports .
Hello there! I saw some issues with the py3 compatibility as well as some documentation quick hits so I figured I'd help out! Thanks for the awesome library!