Refactored load & download_bionemo_data into bionemo-core
#412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`bionemo-testing` re-exports the same values defined in `__all__`: they are imported from `bionemo-core` as the implementations have moved. Note that the tests have also moved. Now, all sub-packages can use `load` at runtime, not just during tests. All previous imports of `bionemo.testing.load` have been changed to `bionemo.core.load`. Additionally moves over the YAML resource files from bionemo-testing into bionemo-core & adjusted the `get_all_resources` function. This PR also fixes an error in the naming convention for `bionemo-core`'s tests.
malcolmgreaves
requested review from
jstjohn,
polinabinder1,
skothenhill-nv,
DejunL,
dorotat-nv,
farhadrgh,
guoqing-zhou and
pstjohn
as code owners
|
/build-ci |
farhadrgh
approved these changes
Nov 7, 2024
|
Impacts #409 |
jstjohn
approved these changes
Nov 8, 2024
|
/build-ci |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bionemo-testingre-exports the same values defined in__all__: they are imported frombionemo-coreas the implementations have moved. Note that the tests have also moved.Now, all sub-packages can use
loadat runtime, not just during tests.All previous imports of
bionemo.testing.loadhave been changed tobionemo.core.load.Additionally moves over the YAML resource files from bionemo-testing into bionemo-core & adjusted the
get_all_resourcesfunction.This PR also fixes an error in the naming convention for
bionemo-core's tests.