Small performance improvement to process_item
#395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…improvements to process
jstjohn
requested review from
malcolmgreaves and
skothenhill-nv
as code owners
malcolmgreaves
requested changes
Nov 4, 2024
There was a problem hiding this comment.
LGTM but needs changes because of imports. bionemo-testing isn't a main, run-time dependency for bionemo-geneformer. It's a test-time only. To unblock this PR, the load function needs to be moved into bionemo-core and bionemo-testing needs to be refactored to import this so that we don't break backwards compatability.
sub-packages/bionemo-geneformer/src/bionemo/geneformer/data/singlecell/dataset.py
Outdated
Show resolved
Hide resolved
sub-packages/bionemo-geneformer/src/bionemo/geneformer/data/singlecell/dataset.py
Outdated
Show resolved
Hide resolved
sichu2023
approved these changes
Nov 4, 2024
|
/build-ci |
|
/build-ci |
sub-packages/bionemo-geneformer/src/bionemo/geneformer/data/singlecell/dataset.py
Outdated
Show resolved
Hide resolved
…nglecell/dataset.py Co-authored-by: Malcolm Greaves <[email protected]> Signed-off-by: John St. John <[email protected]>
|
/build-ci |
malcolmgreaves
approved these changes
Nov 8, 2024
…hn/process_dataset_perf
|
/build-ci |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Run
python -m bionemo.geneformer.data.singlecell.datasetBaseline:
Processed 31208 rows in 47.10491418838501 seconds
Processed 31208 rows in 47.388004779815674 seconds
After vectorization:
Processed 31208 rows in 44.2215359210968 seconds
Processed 31208 rows in 44.54389500617981 seconds