-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adds nbval test for ngc download #409
adds nbval test for ngc download #409
Conversation
/build-ci |
f7628b7
to
c6265ae
Compare
/build-ci |
c6265ae
to
8612d7d
Compare
/build-ci |
/build-ci |
As a side-note, why didn't CI fail with this bug in the notebook cell? seems like it just powers through even if the cell fails? Wondering what the utility of the notebook test is if it ignores exceptions in the cells? |
Because I made sure my changes were backwards compatible! 🤗 To avoid breaking things, I made |
/build-ci |
Uses
nest_asyncio
to allow this to run in a jupyter notebook, and callsclient.configure()
to ensure that the output type is set tojson
.