Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds nbval test for ngc download #409

Merged
merged 5 commits into from
Nov 8, 2024

Conversation

pstjohn
Copy link
Collaborator

@pstjohn pstjohn commented Nov 7, 2024

Uses nest_asyncio to allow this to run in a jupyter notebook, and calls client.configure() to ensure that the output type is set to json.

@pstjohn
Copy link
Collaborator Author

pstjohn commented Nov 7, 2024

/build-ci

@pstjohn pstjohn force-pushed the pstjohn/main/test-ngcsdk-in-jupyter branch from f7628b7 to c6265ae Compare November 7, 2024 19:14
@pstjohn
Copy link
Collaborator Author

pstjohn commented Nov 7, 2024

/build-ci

@pstjohn pstjohn force-pushed the pstjohn/main/test-ngcsdk-in-jupyter branch from c6265ae to 8612d7d Compare November 8, 2024 16:18
@pstjohn
Copy link
Collaborator Author

pstjohn commented Nov 8, 2024

/build-ci

@pstjohn
Copy link
Collaborator Author

pstjohn commented Nov 8, 2024

/build-ci

@jstjohn
Copy link
Collaborator

jstjohn commented Nov 8, 2024

As a side-note, why didn't CI fail with this bug in the notebook cell? seems like it just powers through even if the cell fails? Wondering what the utility of the notebook test is if it ignores exceptions in the cells?

@malcolmgreaves
Copy link
Collaborator

As a side-note, why didn't CI fail with this bug in the notebook cell? seems like it just powers through even if the cell fails? Wondering what the utility of the notebook test is if it ignores exceptions in the cells?

Because I made sure my changes were backwards compatible! 🤗 To avoid breaking things, I made bionemo.testing.load re-export the public things defined in bionemo.core.load [1]. This way, a from bionemo.testing.load import load still works as expected and we have what we want: the ability to use load w/o needing to use bionemo-testing.

[1] https://github.com/NVIDIA/bionemo-framework/blob/main/sub-packages/bionemo-testing/src/bionemo/testing/data/load.py#L17-L31

@pstjohn
Copy link
Collaborator Author

pstjohn commented Nov 8, 2024

/build-ci

@pstjohn pstjohn enabled auto-merge (squash) November 8, 2024 18:58
@pstjohn pstjohn merged commit bc431ff into NVIDIA:main Nov 8, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants