Replace ref with absolute git commit in output source_info #72

efajardo-nv · 2025-02-04T21:58:56Z

Update build_vdb_stage to replace the ref with the git commit in each SourceDocumentsInfo object

ashsong-nv

Very clean, thank you! Couple of minor comments

src/cve/pipeline/input.py

src/cve/data_models/input.py

ashsong-nv

Looks great, thanks @efajardo-nv !

efajardo-nv added 2 commits February 4, 2025 16:54

Add git commit to source_info

dac955f

typo fix

4635f17

ashsong-nv reviewed Feb 4, 2025

View reviewed changes

src/cve/pipeline/input.py Outdated Show resolved Hide resolved

src/cve/data_models/input.py Outdated Show resolved Hide resolved

efajardo-nv added 3 commits February 4, 2025 17:48

Update config schema

ecac8fb

Update to add git commits in build_vdb_stage instead

aea5f8a

Remove unused logger

45bfc6c

ashsong-nv reviewed Feb 6, 2025

View reviewed changes

src/cve/data_models/input.py Show resolved Hide resolved

src/cve/data_models/input.py Outdated Show resolved Hide resolved

efajardo-nv added 2 commits February 6, 2025 13:39

Add source_info ref validation

8286e70

Update source_info ref to git commit

b6f4837

ashsong-nv mentioned this pull request Feb 6, 2025

Standardize refs to git commits before generating VDB #74

Open

ashsong-nv changed the title ~~Add git commit to source_info~~ Replace ref with absolute git commit in output source_info Feb 6, 2025

ashsong-nv approved these changes Feb 6, 2025

View reviewed changes

ashsong-nv merged commit d312e7c into NVIDIA-AI-Blueprints:main Feb 6, 2025

Provide feedback