New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standardize refs to git commits before generating VDB #74

Open

ashsong-nv opened this issue Feb 6, 2025 · 0 comments

Labels

accuracy bug enhancement P1

Collaborator

ashsong-nv commented Feb 6, 2025

With #72, we are currently overwriting the ref with the absolute git commit after VDB creation is finished. However this has a couple of issues:

Switching from a branch ref to a commit will result in a new VDB being generated even if they are from the same absolute commit
When a mutable ref like a branch changes to a new commit, we will still use the cached VDB for the older commit since the ref name is the same

To avoid this issue, we should standardize refs to the absolute git commit before creating the VDB.

ashsong-nv added bug enhancement labels

ashsong-nv mentioned this issue

Replace ref with absolute git commit in output source_info #72

Merged

ashsong-nv added P1 accuracy labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment