Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] EUSS/SDR: roof/window measure updates and combining with HP-RTU measure #276

Open
wants to merge 28 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
3868f31
take out unused var
JanghyunJK Jan 24, 2025
5024f89
resource file creation
JanghyunJK Jan 24, 2025
89a3abb
link to resource file in measure.rb
JanghyunJK Jan 24, 2025
b30fff6
revise resource file structure: returning initial/final conditions
JanghyunJK Jan 24, 2025
96e7fb6
link roof measure to resource file in hprtu measure
JanghyunJK Jan 24, 2025
90b7a31
misc note/rubocop
JanghyunJK Jan 24, 2025
47acd8e
window measure restructure and rubocop
JanghyunJK Jan 24, 2025
eceb167
rubocop on roof resource code
JanghyunJK Jan 24, 2025
2ce9260
update resource files under hprtu measure folder
JanghyunJK Jan 24, 2025
37c2088
add window as new argument
JanghyunJK Jan 24, 2025
4d7eadb
initial/final conditions revision on hprtu measure
JanghyunJK Jan 24, 2025
50d3322
update unit test: new argument
JanghyunJK Jan 24, 2025
44a41c3
proper argument get
JanghyunJK Jan 24, 2025
214d604
append window measure's initial conditions
JanghyunJK Jan 24, 2025
e47a972
combining initial/final conditions more appropriately
JanghyunJK Jan 24, 2025
8b66b61
better joining of initial conditions for window measure
JanghyunJK Jan 24, 2025
659034b
unit test update with window/roof measure testing
JanghyunJK Jan 24, 2025
1e76485
add copyright
JanghyunJK Jan 24, 2025
c8f9e92
unit test for checking window measure
JanghyunJK Jan 28, 2025
62b3f3c
options lookup update (adding window arg)
JanghyunJK Feb 27, 2025
bad57a8
update approach for calling other measures
JanghyunJK Mar 10, 2025
f6db174
additional changes for sub-measures for more logging
JanghyunJK Mar 10, 2025
3fdab18
misc
JanghyunJK Mar 10, 2025
3ff580e
misc unit test update for sub-measure testing
JanghyunJK Mar 10, 2025
f6600ad
adding roof plus window in options lookup
JanghyunJK Mar 12, 2025
79066af
reverting roof/window measures to main
JanghyunJK Mar 12, 2025
e9053d5
check if initial/final conditions are initialized
JanghyunJK Mar 12, 2025
a761303
rubocop
JanghyunJK Mar 13, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
72 changes: 37 additions & 35 deletions national/housing_characteristics/options_lookup.tsv

Large diffs are not rendered by default.

3 changes: 0 additions & 3 deletions resources/measures/upgrade_env_roof_insul_aedg/measure.rb
Original file line number Diff line number Diff line change
Expand Up @@ -75,9 +75,6 @@ def run(model, runner, user_arguments)
# set limit for minimum insulation in IP units -- this is used to limit input and for inferring insulation layer in construction
min_exp_r_val_ip = 1.0

# build standard to use OS standards methods
template = 'ComStock 90.1-2019'
std = Standard.build(template)
# get climate zone to set target_r_val_ip
climate_zone = OpenstudioStandards::Weather.model_get_climate_zone(model)

Expand Down
10 changes: 5 additions & 5 deletions resources/measures/upgrade_env_roof_insul_aedg/measure.xml
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@
<schema_version>3.1</schema_version>
<name>env_roof_insul_aedg</name>
<uid>8afedac6-d5b8-4ee6-80d9-107c5cd77b0e</uid>
<version_id>370fdf61-e62c-43a8-8487-0fd098f03fda</version_id>
<version_modified>2024-06-20T18:58:42Z</version_modified>
<version_id>e61c3b69-deb1-4490-9be0-7239edee2788</version_id>
<version_modified>2024-09-09T21:44:40Z</version_modified>
<xml_checksum>A465C8A5</xml_checksum>
<class_name>EnvRoofInsulAedg</class_name>
<display_name>Roof Insulation AEDG</display_name>
Expand Down Expand Up @@ -81,13 +81,13 @@
<filename>measure.rb</filename>
<filetype>rb</filetype>
<usage_type>script</usage_type>
<checksum>E6813C8D</checksum>
<checksum>5B95CB09</checksum>
</file>
<file>
<filename>env_roof_insul_aedg_test.rb</filename>
<filename>upgrade_env_roof_insul_aedg_test.rb</filename>
<filetype>rb</filetype>
<usage_type>test</usage_type>
<checksum>E22EA670</checksum>
<checksum>2C804AFF</checksum>
</file>
</files>
</measure>
Original file line number Diff line number Diff line change
Expand Up @@ -116,9 +116,6 @@ def apply_measure_and_run(test_name, measure, argument_map, osm_path, epw_path,
end
assert(File.exist?(run_dir(test_name)))

# change into run directory for tests
start_dir = Dir.pwd
Dir.chdir run_dir(test_name)

# remove prior runs if they exist
if File.exist?(model_output_path(test_name))
Expand All @@ -128,19 +125,14 @@ def apply_measure_and_run(test_name, measure, argument_map, osm_path, epw_path,
FileUtils.rm(report_path(test_name))
end

# copy the osm and epw to the test directory
new_osm_path = "#{run_dir(test_name)}/#{File.basename(osm_path)}"
FileUtils.cp(osm_path, new_osm_path)
new_epw_path = "#{run_dir(test_name)}/#{File.basename(epw_path)}"
FileUtils.cp(epw_path, new_epw_path)
# create an instance of a runner
runner = OpenStudio::Measure::OSRunner.new(OpenStudio::WorkflowJSON.new)

# load the test model
model = load_model(new_osm_path)
model = load_model(osm_path)

# set model weather file
epw_file = OpenStudio::EpwFile.new(OpenStudio::Path.new(new_epw_path))
epw_file = OpenStudio::EpwFile.new(OpenStudio::Path.new(epw_path))
OpenStudio::Model::WeatherFile.setWeatherFile(model, epw_file)
assert(model.weatherFile.is_initialized)

Expand All @@ -166,9 +158,6 @@ def apply_measure_and_run(test_name, measure, argument_map, osm_path, epw_path,
assert(File.exist?(sql_path(test_name)))
end

# change back directory
Dir.chdir(start_dir)

return result
end

Expand Down
9 changes: 9 additions & 0 deletions resources/measures/upgrade_hvac_add_heat_pump_rtu/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,15 @@ Upgrade roof insulation per AEDG recommendations.
**Model Dependent:** false


### Upgrade Windows?
Upgrade window per AEDG recommendations.
**Name:** window,
**Type:** Boolean,
**Units:** ,
**Required:** true,
**Model Dependent:** false


### Do a sizing run for informing sizing instead of using hard-sized model parameters?

**Name:** sizing_run,
Expand Down
Loading