-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] EUSS/SDR: roof/window measure updates and combining with HP-RTU measure #276
base: main
Are you sure you want to change the base?
Conversation
update options lookup! |
made additional structural changes based on meetings with @ChristopherCaradonna @mpraprost @eringold. in short, it is (1) using parent/child runners, (2) call (child) measure within (parent) measure, and (3) better for minimizing redundant files. Examples shown below: ComStock/resources/measures/upgrade_hvac_add_heat_pump_rtu/measure.rb Lines 1129 to 1147 in 3fdab18
ComStock/resources/measures/upgrade_hvac_add_heat_pump_rtu/resources/call_other_measures.rb Lines 40 to 111 in 3fdab18
|
Pull request overview
- roof upgrade measure update- most functionality moved toComStock\resources\measures\upgrade_env_roof_insul_aedg\resources\upgrade_env_roof_insul_aedg.rb
- window upgrade measure update- most functionality moved toComStock\resources\measures\upgrade_env_new_aedg_windows\resources\upgrade_env_new_aedg_windows.rb
- HP-RTU measure update- the "exact same" two files above are saved under this measure folder:ComStock\resources\measures\upgrade_hvac_add_heat_pump_rtu\resources
- to provide the same functionality of roof/window upgrade measures inside of HP-RTU measure- but to use HP-RTU applicability logic as the sole applicability logic- minimum unit test added to check if window/roof measures are implemented or not implemented correctly- so, based on the suggestion in this PR,~~- whenever someone makes changes to either of these two files below, ~~
ComStock\resources\measures\upgrade_env_roof_insul_aedg\resources\upgrade_env_roof_insul_aedg.rb
ComStock\resources\measures\upgrade_env_new_aedg_windows\resources\upgrade_env_new_aedg_windows.rb
- then the same change should happen here:ComStock\resources\measures\upgrade_hvac_add_heat_pump_rtu\resources
- and vise versaRefer to a comment below for correct details
Pull Request Author
This pull request makes changes to (select all the apply):
Author pull request checklist:
comstock_column_definitions.csv
options_lookup.tsv
files updated.yml
filesREADME.md
filestest/reporting_measure_tests.txt
,test/workflow_measure_tests.txt
, ortest/upgrade_measure_tests.txt
Review Checklist
This will not be exhaustively relevant to every PR.