Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add check flags to GNU CI and fix for data_override ci failures #1579

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

rem1776
Copy link
Contributor

@rem1776 rem1776 commented Aug 29, 2024

Description
Adds the debug flags from the mkmf template to the gnu CI, now that all the tests should be passing with them. (draft cause this will need #1575 in first)

I also included an attempt to fix the issue below where a data_override test occasionally fails, hopefully the sync call gives it enough time for the file system to catch up with the test and not throw the netcdf error. I can't know for sure if it works cause it only happens like 1/100 runs.

Fixes #1480 (maybe.. 🤞)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included
  • make distcheck passes

@rem1776 rem1776 requested a review from J-Lentz August 29, 2024 14:56
@rem1776 rem1776 marked this pull request as ready for review August 29, 2024 15:00
@rem1776 rem1776 marked this pull request as draft September 5, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test_data_override sporadic failures in CI testing
1 participant