Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mixed precision monin_obukhov #1116

Merged
merged 88 commits into from
Jul 28, 2023
Merged
Show file tree
Hide file tree
Changes from 86 commits
Commits
Show all changes
88 commits
Select commit Hold shift + click to select a range
9daaee0
Merge mixedmode
mcallic2 Jan 20, 2023
660c88a
Remove subroutines/functions from incorrect files
mcallic2 Jan 20, 2023
afd8611
Add platform_mod
mcallic2 Jan 20, 2023
3332fa5
Changes interface precision
mcallic2 Jan 20, 2023
a25ff52
Adds public interfaces
mcallic2 Jan 20, 2023
fe30a4f
Adds #include statements
mcallic2 Jan 20, 2023
d12b365
Adds header files
mcallic2 Jan 20, 2023
e1a2503
Adds new files
mcallic2 Jan 20, 2023
8c1057b
Adds double precision
mcallic2 Jan 23, 2023
5f2706e
Change routine/function name to macros
mcallic2 Jan 23, 2023
425c33c
Adds mixed precision
mcallic2 Jan 23, 2023
6567823
Adds dimension size changing loop
mcallic2 Jan 24, 2023
14aba67
Merge branch 'NOAA-GFDL:main' into monin_obukhov
mcallic2 Jan 24, 2023
48789cb
Changes interface call naming
mcallic2 Jan 24, 2023
5812045
Removes unnecessary precision
mcallic2 Jan 25, 2023
2b8a213
Fixes module variable precision
mcallic2 Jan 25, 2023
8964a74
Merge branch 'main' of github.com:mcallic2/FMS into monin_obukhov
mcallic2 Jan 25, 2023
644f3c0
Merge branch 'monin_obukhov' of github.com:mcallic2/FMS into monin_ob…
mcallic2 Jan 25, 2023
9f31cbc
Removes trailing whitespace
mcallic2 Jan 25, 2023
8e59785
Fixes long lines
mcallic2 Jan 25, 2023
08e90d9
Fixes more long lines
mcallic2 Jan 25, 2023
cc33e41
Changes for cmake
mcallic2 Jan 25, 2023
485d631
fix: misspellings and rename variable in yaml_parser.F90 (#1127)
J-Lentz Feb 1, 2023
35a5f2a
fix: module and local variable name conflicts in time_interp (#1125)
mlee03 Feb 1, 2023
ba9c712
docs: Correct instructions to build without MPI (#1128)
J-Lentz Feb 1, 2023
0a24d85
Merge mixedmode updated
mcallic2 Feb 8, 2023
15df841
fix: pointer to allocatable in amip_interp_type (#1106)
ganganoaa Feb 9, 2023
f0e8cab
feat: log_diag_field_info updates from diag rewrite (#1117)
rem1776 Feb 14, 2023
ec2020a
fix: remove implied save for valid_types variables in sat_vapor_pres_…
uramirez8707 Feb 16, 2023
4526cc9
revert: log_diag_field_info argument changes (#1136)
rem1776 Feb 16, 2023
5a66f27
Changes for expoential value precsion
mcallic2 Feb 23, 2023
6255971
feat: refactored send_data math (field buffer update) functions. (#1131)
ngs333 Feb 23, 2023
c18acde
Change character line length
mcallic2 Feb 24, 2023
3bd2cf8
Fixes missed exponentials and comments
mcallic2 Feb 24, 2023
df07cb6
Missed real values
mcallic2 Feb 24, 2023
07bd81a
Changes implicit casting to explicit casting
mcallic2 Feb 24, 2023
74d8e73
fix: adds tags to nested do loops in fms_diag_fieldbuff.fh to fix his…
ngs333 Feb 27, 2023
9b83c8c
fix - gnu and pgi issue with class(*) in send_data3d (#1149)
nikizadehgfdl Mar 9, 2023
9339b88
feat: extend `string` interface in `fms_string_utils_mod` (#1142)
J-Lentz Mar 9, 2023
0ff254e
fix: add omp directives for race condition in tridiagonal (#1109)
ganganoaa Mar 9, 2023
6362657
fix: missing if statement in PR #1149 (#1155)
nikizadehgfdl Mar 13, 2023
7188e3a
fix: time_manager missing changes from year to yr, month to mo, day t…
mlee03 Mar 28, 2023
8a78fac
chore: update changelog and version numbers for release (#1167)
rem1776 Apr 3, 2023
003b8e1
chore: append dev to version number post-release (#1179)
github-actions[bot] Apr 6, 2023
eab5f8b
merge mixedmode
mcallic2 Jun 4, 2023
b37e58e
Removes unecessary path
mcallic2 Jun 4, 2023
f8df113
Removes repeated lines from .F90 file
mcallic2 Jun 4, 2023
4ac63cf
Removes repeated lines from .F90 file
mcallic2 Jun 4, 2023
3293069
Removes old include files
mcallic2 Jun 4, 2023
011b510
feat: merge 2023.01.01 changes into main (#1259)
rem1776 Jun 16, 2023
23b86db
feat: mixed precision for axis_utils2, horiz_interp, sat_vapor_pressu…
rem1776 Jun 16, 2023
af15993
fix: replace current_peset_num with 'n' which should be the active pe…
dkokron Jun 16, 2023
de03798
fix: gcc class(*) bug workaround for character arrays (#1163)
laurenchilutti Jun 16, 2023
16d71a2
fix: improve error messages in fms2_io (#1183)
uramirez8707 Jun 16, 2023
22c498e
feat: fms2_io unpack data (#1231)
uramirez8707 Jun 16, 2023
cf5035f
fix: improve doxygen comment for `tranlon` (#1257)
J-Lentz Jun 20, 2023
ecc1361
fix: ifort 2022.3.0 & greater ICE bug in alltoall test + missing inpu…
rem1776 Jun 20, 2023
783019f
fix: checks placed before allocating pointers passed into routines (#…
ganganoaa Jun 20, 2023
5e130ef
fix: continuation line syntax for fms2_io error messages (#1265)
J-Lentz Jun 27, 2023
84b330a
fix: update doc site deployment action(#1078)
rem1776 Jun 29, 2023
ef8b5e3
fix: warnings in test_mpp_nesting.F90 (#1118)
rem1776 Jun 29, 2023
3138e4a
chore!: deprecate fms/mpp_io with use_deprecated_io macro (#1064)
mcallic2 Jun 30, 2023
cbceb9f
fix: field exists check for io update (#1193)
J-Lentz Jun 30, 2023
46e55f2
fix: diag_fieldbuff_update module dependency in Makefile.am (#1266)
ngs333 Jun 30, 2023
8c73bd1
chore: add deprecated io options to build systems and CI (#1063)
rem1776 Jun 30, 2023
dbed2ce
fix: test errors from io flag (#1271)
rem1776 Jul 5, 2023
2349529
changes format of exponential numbers
mcallic2 Jul 6, 2023
7831d2e
CI: update oneapi container version (#1277)
rem1776 Jul 11, 2023
05337ea
refactor: `monin_obukhov_stable_mix` calls from `stable_mix_1d` (#1268)
J-Lentz Jul 13, 2023
0463dd1
fix: out-of-bounds memory access in axis_utils2 (#1157)
J-Lentz Jul 13, 2023
8eb24f8
fix: maximize system stacksize limit in fms_init (#1233)
J-Lentz Jul 13, 2023
a2471c8
test: remove stack limit checks in test scripts (#1280)
rem1776 Jul 13, 2023
6693a4f
fix: mpp global arrays test fixes (#1174)
rem1776 Jul 13, 2023
e6225ad
feat: update mpp_do_update_ad.fh to resolve JEDI requirement (#1225)
jkbk2004 Jul 13, 2023
2be8aa4
chore: add prefixed aliases for libfms routines (#1262)
rem1776 Jul 13, 2023
38c7c69
exponentials with kind parameter
mcallic2 Jul 19, 2023
643a076
missed exponential
mcallic2 Jul 19, 2023
f9cb3bd
split mo_integral interface into two, also missed a comma from last c…
mcallic2 Jul 19, 2023
585aed6
merge mixedmode
mcallic2 Jul 27, 2023
f5ee87e
merge main
mcallic2 Jul 27, 2023
4c25d2b
merge conflicts can be hard
mcallic2 Jul 27, 2023
fd47979
removes unnessary precision
mcallic2 Jul 27, 2023
1f52200
Merge branch 'mixedmode' into monin_obukhov
mcallic2 Jul 28, 2023
164fa0c
merge mixedmode
mcallic2 Jul 28, 2023
b08705d
git confusion
mcallic2 Jul 28, 2023
180a75c
merge confict
mcallic2 Jul 28, 2023
e4e460f
put these back
mcallic2 Jul 28, 2023
3cd53cd
because jesse told me too
mcallic2 Jul 28, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,6 @@ and this project uses `yyyy.rr[.pp]`, where `yyyy` is the year a patch is releas
`rr` is a sequential release number (starting from `01`), and an optional two-digit
sequential patch number (starting from `01`).

<<<<<<< HEAD
mcallic2 marked this conversation as resolved.
Show resolved Hide resolved
=======
## [2023.01.01] - 2023-06-06
### Changed
- FMS2_IO: Performance changes for domain_reads_2d and domain_reads_3d:
Expand All @@ -23,7 +21,6 @@ sequential patch number (starting from `01`).
- FMS2_IO: Extended mpp_scatter and mpp_gather to work for int8; added a kludge for scatter since the data is assumed to be (x,y,z)


>>>>>>> origin/mixedmode_base
## [2023.01] - 2023-04-03
### Known Issues
- If using GCC 10 or higher as well as MPICH, compilation errors will occur unless `-fallow-argument-mismatch` is included in the Fortran compiler flags(the flag will now be added automatically if building with autotools or CMake).
Expand Down
3 changes: 3 additions & 0 deletions CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -304,6 +304,7 @@ foreach(kind ${kinds})
fms2_io/include
string_utils/include
mpp/include
monin_obukhov/include
sat_vapor_pres/include
horiz_interp/include
random_numbers/include
Expand Down Expand Up @@ -349,6 +350,7 @@ foreach(kind ${kinds})
$<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/fms>
$<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/fms/include>
$<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/fms2_io/include>
$<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/monin_obukhov/include>
$<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/sat_vapor_pres/include>
$<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/field_manager/include>
$<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/horiz_interp/include>
Expand All @@ -359,6 +361,7 @@ foreach(kind ${kinds})
$<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/field_manager/include>
$<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/tracer_manager/include>)


target_include_directories(${libTgt} INTERFACE
$<BUILD_INTERFACE:${moduleDir}>
$<INSTALL_INTERFACE:${includeDir}>)
Expand Down
3 changes: 0 additions & 3 deletions axis_utils/include/axis_utils2.inc
Original file line number Diff line number Diff line change
Expand Up @@ -177,14 +177,11 @@
!! lon = 0 1 2 3 4 5 ... 358 359; lon_strt = 3
!! ==> lon = 3 4 5 6 7 8 ... 359 360 361 362; istrt = 4
!!
!! lon = 0 1 2 3 4 5 ... 358 359; lon_strt = 0
!! ==> lon = 0 1 2 3 4 5 ... 358 359; istrt = 0

subroutine TRANLON_(lon, lon_start, istrt)
real(kind=FMS_AU_KIND_), intent(inout), dimension(:) :: lon
real(kind=FMS_AU_KIND_), intent(in) :: lon_start
integer, intent(out) :: istrt

integer :: len, i
real(kind=FMS_AU_KIND_) :: lon_strt, tmp(size(lon(:))-1)

Expand Down
31 changes: 23 additions & 8 deletions monin_obukhov/Makefile.am
Original file line number Diff line number Diff line change
Expand Up @@ -22,24 +22,39 @@

# Ed Hartnett 2/22/19

AM_CPPFLAGS = -I$(top_srcdir)/include
AM_CPPFLAGS = -I$(top_srcdir)/include -I$(top_srcdir)/monin_obukhov/include
AM_FCFLAGS = $(FC_MODINC). $(FC_MODOUT)$(MODDIR)

noinst_LTLIBRARIES = libmonin_obukhov.la

libmonin_obukhov_la_SOURCES = \
monin_obukhov.F90 \
monin_obukhov_inter.F90

monin_obukhov_mod.$(FC_MODEXT): monin_obukhov_inter.$(FC_MODEXT)
monin_obukhov.F90 \
monin_obukhov_inter.F90 \
include/monin_obukhov_r4.fh \
include/monin_obukhov_r8.fh \
include/monin_obukhov.inc \
include/monin_obukhov_inter_r4.fh \
include/monin_obukhov_inter_r8.fh \
include/monin_obukhov_inter.inc

monin_obukhov_inter.$(FC_MODEXT): \
include/monin_obukhov_inter_r4.fh \
include/monin_obukhov_inter_r8.fh \
include/monin_obukhov_inter.inc

monin_obukhov_mod.$(FC_MODEXT): \
monin_obukhov_inter.$(FC_MODEXT) \
include/monin_obukhov_r4.fh \
include/monin_obukhov_r8.fh \
include/monin_obukhov.inc

# Mod files are built and then installed as headers.
MODFILES = \
monin_obukhov_inter.$(FC_MODEXT) \
monin_obukhov_mod.$(FC_MODEXT)
monin_obukhov_mod.$(FC_MODEXT) \
monin_obukhov_inter.$(FC_MODEXT)
nodist_include_HEADERS = $(MODFILES)
BUILT_SOURCES = $(MODFILES)

EXTRA_DIST = monin_obukhov.tech.ps

include $(top_srcdir)/mkmods.mk
include $(top_srcdir)/mkmods.mk
Loading
Loading