Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RRFS IFI crash fix + debug mode change #852

Merged
merged 5 commits into from
Jan 12, 2024

Conversation

SamuelTrahanNOAA
Copy link
Contributor

@SamuelTrahanNOAA SamuelTrahanNOAA commented Jan 11, 2024

This fixes the RRFS IFI crash, which was caused by incorrect error handling for extreme values of potential temperature.

Also, it enables libIFI's own debug mode (-DIFI_DEBUG=ON) when UPP is built with inline IFI (-I) and debug (-d). That debug mode enables bounds checking and other safeguards. It also causes uncaught C++ exceptions to pass through to Fortran. That usually results in a stack trace or core dump to the point in the C++ library that raised the exception. (Without debug mode, C++ returns an integer error code to Fortran.)

@WenMeng-NOAA
Copy link
Collaborator

@SamuelTrahanNOAA Can you sync your branch with the latest UPP develop?

Copy link
Contributor

@MatthewPyle-NOAA MatthewPyle-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to see this problem being fixed so quickly. Can't comment on the IFI changes, but like the compile modification to utilize debug options for IFI when appropriate.

@WenMeng-NOAA
Copy link
Collaborator

@SamuelTrahanNOAA @MatthewPyle-NOAA
I did two tests:
test 1:
UPP version: current UPP develop
RRFS data file: RRFS parallel failure case '2023122706_case'
run directory: /u/wen.meng/ptmp/post_rrfs_2023122706-fail
** This test failed at IFI* file generation.

test 2:
UPP version: Sam's PR #852
RRFS data file: RRFS parallel failure case '2023122706_case'
run directory: /u/wen.meng/ptmp/post_rrfs_2023122706-sam-fix
** This test was successfully completed.

It appears to me that Sam's fix is working. Please let me know if you see issues in my tests.

@SamuelTrahanNOAA
Copy link
Contributor Author

My tests finished:

  • Matt Pyle's case: passed on WCOSS
  • Shun Liu's case: passed on WCOSS and Hera

@WenMeng-NOAA
Copy link
Collaborator

@SamuelTrahanNOAA Is your PR available for final testing? If yes, please sync with the UPP develop.

@SamuelTrahanNOAA
Copy link
Contributor Author

@WenMeng-NOAA - It is ready for testing. The libIFI PR was merged and the branch is up to date.

@WenMeng-NOAA WenMeng-NOAA added Ready for Review This PR is ready for code review. No Baseline Change No baseline of the UPP regression tests are made. labels Jan 12, 2024
@WenMeng-NOAA
Copy link
Collaborator

The UPP RTs were completed on WCOSS2, Hera and Orion without changed results. This PR is ready for merging.

@WenMeng-NOAA WenMeng-NOAA merged commit 5c4372e into NOAA-EMC:develop Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
No Baseline Change No baseline of the UPP regression tests are made. Ready for Review This PR is ready for code review. RRFS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Getting some failures with RRFS configuration
3 participants