-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RRFS IFI crash fix + debug mode change #852
RRFS IFI crash fix + debug mode change #852
Conversation
@SamuelTrahanNOAA Can you sync your branch with the latest UPP develop? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great to see this problem being fixed so quickly. Can't comment on the IFI changes, but like the compile modification to utilize debug options for IFI when appropriate.
@SamuelTrahanNOAA @MatthewPyle-NOAA test 2: It appears to me that Sam's fix is working. Please let me know if you see issues in my tests. |
My tests finished:
|
@SamuelTrahanNOAA Is your PR available for final testing? If yes, please sync with the UPP develop. |
@WenMeng-NOAA - It is ready for testing. The libIFI PR was merged and the branch is up to date. |
The UPP RTs were completed on WCOSS2, Hera and Orion without changed results. This PR is ready for merging. |
This fixes the RRFS IFI crash, which was caused by incorrect error handling for extreme values of potential temperature.
Also, it enables libIFI's own debug mode (-DIFI_DEBUG=ON) when UPP is built with inline IFI (-I) and debug (-d). That debug mode enables bounds checking and other safeguards. It also causes uncaught C++ exceptions to pass through to Fortran. That usually results in a stack trace or core dump to the point in the C++ library that raised the exception. (Without debug mode, C++ returns an integer error code to Fortran.)