Skip to content

Commit

Permalink
RRFS IFI crash fix + debug mode change (#852)
Browse files Browse the repository at this point in the history
* When building for debug with internal ifi, enable ifi debug too

* libIFI: fix for RRFS crash (tested on Hera but not WCOSS yet

* libIFI: use thetaW extreme value instead of inserting missing value

* point to head of main libIFI
  • Loading branch information
SamuelTrahanNOAA authored Jan 12, 2024
1 parent 8dc4329 commit 5c4372e
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 1 deletion.
2 changes: 1 addition & 1 deletion sorc/libIFI.fd
9 changes: 9 additions & 0 deletions tests/compile_upp.sh
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,14 @@ while getopts ":p:gwc:vhiId" opt; do
;;
esac
done

if [[ ! -z $debug_opt && $ifi_opt =~ INTERNAL.*=ON ]] ; then
echo ENABLING IFI DEBUG
# When building debug mode with internal IFI, also enable debugging in IFI.
# This includes bounds checking in much of the libIFI C++ library.
debug_opt="$debug_opt -DIFI_DEBUG=ON"
fi

cmake_opts=" -DCMAKE_INSTALL_PREFIX=$prefix"${wrfio_opt}${gtg_opt}${ifi_opt}${debug_opt}

if [[ $(uname -s) == Darwin ]]; then
Expand Down Expand Up @@ -112,6 +120,7 @@ if [[ $MACHINE_ID != "unknown" ]]; then
module list
fi

set -x
BUILD_DIR=${BUILD_DIR:-"build"}
rm -rf ${BUILD_DIR} install
mkdir -p ${BUILD_DIR} && cd ${BUILD_DIR}
Expand Down

0 comments on commit 5c4372e

Please sign in to comment.