Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix company edition image upload #319

Merged
merged 3 commits into from
May 14, 2023

Conversation

marco-vb
Copy link

@marco-vb marco-vb commented May 1, 2023

No description provided.

@marco-vb marco-vb linked an issue May 1, 2023 that may be closed by this pull request
@render
Copy link

render bot commented May 1, 2023

@Naapperas Naapperas changed the title Added check to see if image is valid using multer Fix company edition image upload May 1, 2023
@codecov
Copy link

codecov bot commented May 1, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01 🎉

Comparison is base (6064fcd) 90.32% compared to head (f698ee0) 90.33%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #319      +/-   ##
===========================================
+ Coverage    90.32%   90.33%   +0.01%     
===========================================
  Files           54       54              
  Lines         1467     1469       +2     
  Branches       242      245       +3     
===========================================
+ Hits          1325     1327       +2     
  Misses         137      137              
  Partials         5        5              
Impacted Files Coverage Δ
src/api/routes/company.js 88.65% <ø> (ø)
src/api/middleware/files.js 80.95% <100.00%> (+0.95%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Reused FileMiddleware's ParseSingleFile, just added optional 'required'
parameter because logo is not required to be sent in company editing.
@marco-vb marco-vb force-pushed the 318-fix-image-upload-on-company-edit branch from 16dc84c to 885f3d3 Compare May 1, 2023 18:27
marco-vb added 2 commits May 1, 2023 23:17
@marco-vb marco-vb merged commit 4ab4f74 into develop May 14, 2023
@marco-vb marco-vb deleted the 318-fix-image-upload-on-company-edit branch May 14, 2023 21:08
@marco-vb marco-vb restored the 318-fix-image-upload-on-company-edit branch October 25, 2023 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix image upload on company edit
2 participants