Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix image upload on company edit #318

Closed
Naapperas opened this issue Apr 24, 2023 · 0 comments · Fixed by #319
Closed

Fix image upload on company edit #318

Naapperas opened this issue Apr 24, 2023 · 0 comments · Fixed by #319
Assignees
@marco-vb
Labels
bug Something isn't working P0 High priority

Comments

@Naapperas
Copy link
Member

#308 implemented logo changes by just replacing the URL. This should be handled by a file upload middleware (such as multer, which is already used on another route) so that we can validate various aspects about the logo.
@Naapperas Naapperas added bug Something isn't working P0 High priority labels Apr 24, 2023
@marco-vb marco-vb self-assigned this Apr 25, 2023
@marco-vb marco-vb linked a pull request May 1, 2023 that will close this issue
Fix company edition image upload #319
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marco-vb marco-vb

Labels
bug Something isn't working P0 High priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix company edition image upload NIAEFEUP/nijobs-be
2 participants
@Naapperas @marco-vb