Feature/edit company details #308

marco-vb · 2023-02-14T18:27:49Z

No description provided.

render · 2023-02-14T18:27:56Z

Your Render PR Server URL is https://nijobs-backend-pr-308.onrender.com.

Follow its progress at https://dashboard.render.com/web/srv-cflt59p4reb319msmn8g.

marco-vb · 2023-02-14T18:29:35Z

Please review the tests to see if they are good and complete or if I need to add more test cases.

BrunoRosendo

Good job so far! I left some suggestions

src/api/middleware/company.js

src/api/middleware/validators/company.js

test/end-to-end/company.js

codecov-commenter · 2023-02-28T00:40:29Z

Codecov Report

Patch coverage: 84.37% and project coverage change: -0.20 ⚠️

Comparison is base (fd829d7) 90.33% compared to head (e694e77) 90.13%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files

@@             Coverage Diff             @@
##           develop     #308      +/-   ##
===========================================
- Coverage    90.33%   90.13%   -0.20%     
===========================================
  Files           54       54              
  Lines         1417     1440      +23     
  Branches       232      232              
===========================================
+ Hits          1280     1298      +18     
- Misses         132      137       +5     
  Partials         5        5

Impacted Files	Coverage Δ
src/api/middleware/company.js	`90.19% <71.42%> (-3.56%)`	⬇️
src/services/company.js	`81.25% <75.00%> (-2.36%)`	⬇️
src/api/routes/company.js	`87.91% <91.66%> (+0.57%)`	⬆️
src/api/middleware/validators/company.js	`100.00% <100.00%> (ø)`
src/services/offer.js	`99.17% <100.00%> (+0.02%)`	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

BrunoRosendo

Looks good, I left some suggestions. It'd probably be nice to get the company from db/service after editing and checking if everything is ok, at least in one test

src/api/middleware/company.js

src/services/offer.js

test/end-to-end/company.js

src/api/middleware/company.js

src/services/offer.js

src/services/company.js

test/end-to-end/company.js

…MPANY_EDIT_NOTIFICATION to the templates

… added by me

…(were not being used)

… for blocked and disabled companies

…etails

… before starting the actual tests, as suggested

BrunoRosendo

lgtm, maybe @Naapperas wants to re-review

src/services/offer.js

test/end-to-end/company.js

…erefore obviously don't change the company)

marco-vb requested review from Naapperas and BrunoRosendo February 14, 2023 18:30

BrunoRosendo requested changes Feb 16, 2023

View reviewed changes

marco-vb requested a review from BrunoRosendo February 28, 2023 11:11

BrunoRosendo requested changes Feb 28, 2023

View reviewed changes

src/api/middleware/company.js Show resolved Hide resolved

src/services/offer.js Outdated Show resolved Hide resolved

test/end-to-end/company.js Outdated Show resolved Hide resolved

test/end-to-end/company.js Outdated Show resolved Hide resolved

Naapperas requested changes Feb 28, 2023

View reviewed changes

src/api/middleware/company.js Outdated Show resolved Hide resolved

src/services/offer.js Outdated Show resolved Hide resolved

src/services/company.js Outdated Show resolved Hide resolved

ttoino linked an issue Feb 28, 2023 that may be closed by this pull request

Edit Company details #58

Closed

marco-vb force-pushed the feature/edit-company-details branch 2 times, most recently from 16629f3 to e694e77 Compare February 28, 2023 16:26

marco-vb requested review from Naapperas, Process-ing, FranciscoCardoso913 and dsantosferreira February 28, 2023 16:30

Naapperas requested changes Mar 1, 2023

View reviewed changes

marco-vb added 13 commits March 7, 2023 14:25

Added route to edit company details

f289e85

Changed request from patch to put in route

d0a408f

Added company editing details implementation to services/company.js

6b848c3

Fixed small mistake in route

094720f

Added function sendCompanyEditedNotification to services and added CO…

e4d10be

…MPANY_EDIT_NOTIFICATION to the templates

Added 'edit' validator

c2ff584

Fixed some white space trouble and import trouble

074ef1e

Added some tests that should fail

829a94d

Added tests that should pass

a966f2b

Fixed all tests, removed unnecessary validators and emails previously…

acecde9

… added by me

removed changes to 'CanManageAccountSettings' validator

77c753f

removed changes in validators/company.js that were accidentally left …

7a94454

…(were not being used)

removed trailing spaces

181ab39

marco-vb added 14 commits March 7, 2023 14:25

Added more relevant tests such as fail for no authentication and fail…

cacaef5

… for blocked and disabled companies

Added service to update all offers from a company (based on company ID)

fae9d39

Changed edit company route to update details in changed company offers

ca83681

Added test to see if offers reflect changes in company details

91ca4ed

Used previously defined function 'changeAttributes' to edit company d…

8377f3f

…etails

removed unnecessary comment

cf4450d

fixed 'updateAllOffersByCompanyId' redundancies

07ba8e3

changed function call in route to new name (changeAttributes)

b9d2247

wrote validator support for editing a company

b03dc26

Added validators.edit verification

3267589

updateAllOffersByCompanyId now returns all offers updated

44ae945

Added test to check if offers reflect company changes

9f8e028

fixed describe test names

8cc776f

refactored my tests, removing duplicated code and creating everything…

309de07

… before starting the actual tests, as suggested

marco-vb force-pushed the feature/edit-company-details branch from e694e77 to 309de07 Compare March 7, 2023 15:47

marco-vb requested review from Naapperas and BrunoRosendo March 7, 2023 15:51

BrunoRosendo previously approved these changes Mar 7, 2023

View reviewed changes

Naapperas requested changes Mar 9, 2023

View reviewed changes

marco-vb added 4 commits March 9, 2023 19:39

Fixed test asserts to correct methods

33a248f

Removed redundant testing on tests that return bad HTTPstatus (and th…

0c9e127

…erefore obviously don't change the company)

Changed small detail in services/offer.js

ccf60f7

Refactored my tests to create accounts and companies using shorter code

f04634a

marco-vb dismissed BrunoRosendo’s stale review via f04634a March 9, 2023 21:28

marco-vb requested a review from Naapperas March 9, 2023 21:34

Naapperas approved these changes Mar 9, 2023

View reviewed changes

marco-vb merged commit 4c3cf69 into develop Mar 9, 2023

marco-vb deleted the feature/edit-company-details branch March 9, 2023 21:37

Naapperas assigned marco-vb Apr 24, 2023

Naapperas mentioned this pull request Apr 24, 2023

Fix image upload on company edit #318

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature/edit company details #308

Feature/edit company details #308

marco-vb commented Feb 14, 2023

render bot commented Feb 14, 2023

marco-vb commented Feb 14, 2023

BrunoRosendo left a comment

codecov-commenter commented Feb 28, 2023 •

edited

Loading

BrunoRosendo left a comment

BrunoRosendo left a comment

Feature/edit company details #308

Feature/edit company details #308

Conversation

marco-vb commented Feb 14, 2023

render bot commented Feb 14, 2023

marco-vb commented Feb 14, 2023

BrunoRosendo left a comment

Choose a reason for hiding this comment

codecov-commenter commented Feb 28, 2023 • edited Loading

Codecov Report

BrunoRosendo left a comment

Choose a reason for hiding this comment

BrunoRosendo left a comment

Choose a reason for hiding this comment

codecov-commenter commented Feb 28, 2023 •

edited

Loading