Clean exit on Ctrl+C #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also add more tests
harshil21
commented
Sep 19, 2024
Aman-Anas
reviewed
Sep 19, 2024
JacksonElia
requested changes
Sep 20, 2024
There was a problem hiding this comment.
As I was kinda saying earlier today, I think while this is the "correct" way to do this, it adds too much bloat to the code (plus looks foreign af to new programmers), so I would prefer we put a little more effort into the testing scripts rather than add this to our main code.
harshil21
changed the title
|
alright, reverts the context manager change for the sake of understanding code at first glance. I manually ran Apparently this didn't work on the PI today, but I didn't get to much to time to see why, so hold off on merging for now. |
JacksonElia
approved these changes
Sep 21, 2024
Merged
Co-authored-by: Harshil <[email protected]>
|
Confirmed working on the PI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ignores
SIGINTin the child processes, so Ctrl+C events are cleanly handled within them, making theKeyboardInterrupthandling inmain.pyactually stop() the child processes properly.To be merged after testing on the PI.