-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
State determination #19
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confidence is slowly increasing that our system will indeed work. A full scale integration test (simulation) should iron out the last remaining bugs / quirks.
if len(self._data_points) < 2: | ||
return 0.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd still like us to reconsider fetching a set amount of data packets in get_imu_data_packets()
, so that this condition is never hit and things are a little more consistent overall.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How would we implement that in a way that ensured we didn't have a build up of data?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can tell it, "give me at least 10 packets of data, but if you have more, give it all"
…wered-Rocketry-Club/AirbrakesV2 into state-determination
…wered-Rocketry-Club/AirbrakesV2 into state-determination
Co-authored-by: JacksonElia <[email protected]>
"_speed", | ||
"_zeroed_altitude", | ||
"upside_down", | ||
) | ||
|
||
def __init__(self, data_points: Sequence[EstimatedDataPacket], upside_down: bool = False): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove data_points from init, just set it equal to an empty queue (or whatever it is)
if len(self._data_points) < 2: | ||
return 0.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How would we implement that in a way that ensured we didn't have a build up of data?
""" | ||
# We need at least two data points to calculate the speed: | ||
if len(self._data_points) < 2: | ||
return 0.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should return the speed from the last loop, not 0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done in #22
Implements state determination and transition.
Additional changes:
LandedState
run_main_local
file since we can now run the main file in mock mode.