Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes Portal from DOM when destroying #746

Merged
merged 2 commits into from
Oct 1, 2024
Merged

Conversation

allanlasser
Copy link
Member

Fixes #742

@allanlasser allanlasser changed the base branch from master to sveltekit October 1, 2024 16:15
Copy link

netlify bot commented Oct 1, 2024

Deploy Preview for documentcloud-frontend ready!

Name Link
🔨 Latest commit 7b5889a
🔍 Latest deploy log https://app.netlify.com/sites/documentcloud-frontend/deploys/66fc20d4b06314000839a8b2
😎 Deploy Preview https://deploy-preview-746.muckcloud.com
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@allanlasser allanlasser changed the title Removes Portal from DOM before a navigation change Removes Portal from DOM when destroying Oct 1, 2024
Copy link

github-actions bot commented Oct 1, 2024

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 21.4% 6378 / 29796
🔵 Statements 21.4% 6378 / 29796
🔵 Functions 39.19% 136 / 347
🔵 Branches 57% 346 / 607
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
src/lib/components/layouts/Portal.svelte 100% 100% 100% 100%
Generated in workflow #534 for commit 7b5889a by the Vitest Coverage Report Action

@allanlasser allanlasser merged commit 8e79df7 into sveltekit Oct 1, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modals stay open through navigation and it's not possible to close
2 participants