Merge pull request #746 from MuckRock/allanlasser/issue742

Removes Portal from DOM when destroying

src/lib/components/layouts/Portal.svelte

@@ -2,7 +2,7 @@
 <!-- Source: https://github.com/sveltejs/svelte/issues/3088#issuecomment-1065827485 -->
 
 <script lang="ts">
-  import { onMount, onDestroy } from 'svelte';
+  import { onMount, onDestroy } from "svelte";
 
   export let target: HTMLElement | null | undefined = globalThis.document?.body;
 
@@ -12,18 +12,15 @@
     if (target) {
       target.appendChild(ref);
     }
-  })
+  });
 
-  // this block is almost needless/useless (if not totally) as, on destroy, the ref will no longer exist/be in the DOM anyways
   onDestroy(() => {
-    setTimeout(() => {
-      if (ref?.parentNode) {
-        ref.parentNode?.removeChild(ref);
-      }
-    })
-  })
+    if (target) {
+      target.removeChild(ref);
+    }
+  });
 </script>
 
 <div bind:this={ref} style="display:contents;">
   <slot />
-</div>
+</div>