Fix destroy method

MuckRock · Oct 1, 2024 · 7b5889a · 7b5889a
1 parent ac8cc1e
commit 7b5889a
Showing 1 changed file with 3 additions and 13 deletions.
diff --git a/src/lib/components/layouts/Portal.svelte b/src/lib/components/layouts/Portal.svelte
@@ -3,7 +3,6 @@
 
 <script lang="ts">
   import { onMount, onDestroy } from "svelte";
-  import { beforeNavigate } from "$app/navigation";
 
   export let target: HTMLElement | null | undefined = globalThis.document?.body;
 
@@ -15,19 +14,10 @@
     }
   });
 
-  beforeNavigate(() => {
-    if (ref?.parentNode) {
-      ref.parentNode?.removeChild(ref);
-    }
-  });
-
-  // this block is almost needless/useless (if not totally) as, on destroy, the ref will no longer exist/be in the DOM anyways
   onDestroy(() => {
-    setTimeout(() => {
-      if (ref?.parentNode) {
-        ref.parentNode?.removeChild(ref);
-      }
-    });
+    if (target) {
+      target.removeChild(ref);
+    }
   });
 </script>