Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correctly handle contract without storage items #3

Merged
merged 2 commits into from
Oct 2, 2024

Conversation

whichqua
Copy link

@whichqua whichqua commented Oct 1, 2024

Problem: pathfinder returns an internal error when one tries to fetch a proof for contract without storage items.

Solution: Early return when the root is none.

Problem: pathfinder returns an internal error when one tries to fetch a proof for contract without storage items.

Solution: Early return when the root is none.
@ftheirs ftheirs force-pushed the gm/patch-contract-without-root branch 2 times, most recently from 5cfd52e to 399e1a4 Compare October 1, 2024 16:48
@ftheirs ftheirs force-pushed the gm/patch-contract-without-root branch from 399e1a4 to b45a338 Compare October 1, 2024 17:41
@ftheirs ftheirs self-requested a review October 1, 2024 18:37
Copy link

@ftheirs ftheirs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CI randomly fails. Locally, the reported failing test is working fine and on every attempt, we get a different test that fails. I think that we can merge this!

@whichqua whichqua merged commit 3993381 into snos_requirements Oct 2, 2024
7 checks passed
@whichqua whichqua deleted the gm/patch-contract-without-root branch October 2, 2024 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants