fix: correctly handle contract without storage items #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: pathfinder returns an internal error when one tries to fetch a proof for contract without storage items. Solution: Early return when the root is none.
Merged
9 tasks
whichqua
changed the base branch from
od/rpc/feat/get-class-proof
to
snos_requirements
ftheirs
reviewed
Oct 1, 2024
| @@ -245,6 +249,7 @@ pub async fn get_proof( | |||
| input.contract_address, | |||
| header.number, | |||
| k.view_bits(), | |||
| root.unwrap() | |||
There was a problem hiding this comment.
I'd add a comment about this unwrap not failing because of lines 221
There was a problem hiding this comment.
I will convert to .expect which implies infalability
ftheirs
approved these changes
Oct 1, 2024
|
Fixed in favour of #3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: pathfinder returns an internal error when one tries to fetch a proof for contract without storage items.
Solution: Early return when the root is none.