fix: handle contract commitments for contract without data items #388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: reexecution panics when a contract doesnt have data items Solution: handle the edge case to prevent panics
shamsasari
reviewed
Sep 27, 2024
HermanObst
requested changes
Sep 27, 2024
whichqua
force-pushed
the
gm/internal-error-tree-height
branch
from
2005edc
to
b5d131d
Compare
@HermanObst this branch targets gm/no-possible-convertion where I have added two previously failing blocks. The issue came up when I fixed the conversion issue, I had created a new branch thinking it was unrelated. I hope to merge to that PR then merge to main with those tests. Let me know if that works. |
HermanObst
approved these changes
Oct 2, 2024
HermanObst
added a commit
that referenced
this pull request
Oct 14, 2024
* fix: improve convertion errors to provide more context * fix: better error handling and fix for invalid abi * fix: add tests for blocks, and minor fixes based on review * fix: handle contract commitments for contract without data items (#388) * fix: handle contract commitments for contract without data items Problem: reexecution panics when a contract doesnt have data items Solution: handle the edge case to prevent panics * fix: only one commitment return * Revert "fix: handle contract commitments for contract without data items (#388)" (#394) This reverts commit 0c13f1c. --------- Co-authored-by: Herman Obst Demaestri <[email protected]>
matzayonc
pushed a commit
to matzayonc/snos
that referenced
this pull request
Oct 15, 2024
…strange#387) * fix: improve convertion errors to provide more context * fix: better error handling and fix for invalid abi * fix: add tests for blocks, and minor fixes based on review * fix: handle contract commitments for contract without data items (keep-starknet-strange#388) * fix: handle contract commitments for contract without data items Problem: reexecution panics when a contract doesnt have data items Solution: handle the edge case to prevent panics * fix: only one commitment return * Revert "fix: handle contract commitments for contract without data items (keep-starknet-strange#388)" (keep-starknet-strange#394) This reverts commit 0c13f1c. --------- Co-authored-by: Herman Obst Demaestri <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: reexecution panics when a contract doesnt have data items
Solution: handle the edge case to prevent panics
Requires #387 and Moonsong-Labs/pathfinder#2
Issue Number: N/A
Type
Description
Breaking changes?