-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewriting the action.yml to no longer use the DOCKERFILE #6
Open
Aostojic
wants to merge
24
commits into
main
Choose a base branch
from
fixng_action
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
958ef16
updating dockerfile
8cabd2f
fixing action
db953a4
fixing action
798ea4a
fixing action
9246b48
fixing action
e9d757b
fixing action
487abe6
fixing action
8ca3973
updating action to not use docker
bcc80e3
updating action to not use docker
dc095c9
updating action to not use docker
b0b70fa
updating action to not use docker
dd9a9e3
updating action to not use docker
1c2ead8
updating action to not use docker
6739c02
updating action to not use docker
c221f64
updating action to not use docker
f2877ba
updating action to not use docker
e59ded7
updating action to not use docker
78455e6
updating action to not use docker
9acd824
updating action to not use docker
ccdec98
updating action to not use docker
8b7f107
updating action to not use docker
06e4964
updating action to not use docker
1849704
updating action to not use docker
9ff7bc9
Merge branch 'main' into fixng_action
JFrackson File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -21,4 +21,4 @@ RUN apt-get update &&\ | |
|
||
WORKDIR /github/workspace | ||
|
||
ENTRYPOINT [ "pre-commit" ] | ||
ENTRYPOINT exec pre-commit |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we need to install every connector? And all version 1.0?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this action can be used to run some dbt commands via the hooks, ie
dbt-test
, I believe we need the connectors for that. Maybe we should be installing the latest version of dbt though, any thoughts on that?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, ideally we would need to install every connector and it could be passed as a config. For now, however, I think it's probably fine to keep it like this and install them here. I'd bump to 1.2 for all of them though just to be closer to latest