Rewriting the action.yml to no longer use the DOCKERFILE #6
Conversation
Codecov ReportBase: 100.00% // Head: 100.00% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #6 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 44 44
Lines 1971 1971
Branches 256 256
=========================================
Hits 1971 1971 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
| dbt-core==1.0.0 \ | ||
| dbt-postgres==1.0.0 \ | ||
| dbt-redshift==1.0.0 \ | ||
| dbt-snowflake==1.0.0 \ | ||
| dbt-bigquery==1.0.0 |
There was a problem hiding this comment.
do we need to install every connector? And all version 1.0?
There was a problem hiding this comment.
Since this action can be used to run some dbt commands via the hooks, ie dbt-test, I believe we need the connectors for that. Maybe we should be installing the latest version of dbt though, any thoughts on that?
There was a problem hiding this comment.
Yeah, ideally we would need to install every connector and it could be passed as a config. For now, however, I think it's probably fine to keep it like this and install them here. I'd bump to 1.2 for all of them though just to be closer to latest
What kind of additional documentation where you looking for, I'm not sure how to best address this? |
Rewrote the action,yml workflow so that it installs pre-commit and dbt directly in the github runner so that the pre-commit arguments can be properly passed to pre-commit