Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOP-9653] Test SparkLocalFS on Spark 3.5 #165

Merged
merged 1 commit into from
Oct 10, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions .github/workflows/data/local-fs/matrix.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,12 +16,18 @@ min_excel: &min_excel
java-version: 8
os: ubuntu-latest

max: &max
max_excel: &max_excel
spark-version: 3.4.1
python-version: '3.11'
java-version: 20
os: ubuntu-latest

max: &max
spark-version: 3.5.0
python-version: '3.11'
java-version: 20
os: ubuntu-latest

latest: &latest
spark-version: latest
python-version: '3.11'
Expand All @@ -30,13 +36,13 @@ latest: &latest

matrix:
small:
- <<: *max_excel
- <<: *max
- <<: *min_avro
- <<: *min_excel
full:
- <<: *min
- <<: *min_avro
- <<: *min_excel
- <<: *max_excel
- <<: *max
nightly:
- <<: *min
Expand Down
1 change: 1 addition & 0 deletions tests/.coveragerc
Original file line number Diff line number Diff line change
Expand Up @@ -19,3 +19,4 @@ exclude_lines =
if pyspark_version
spark = SparkSession._instantiatedSession
if log.isEnabledFor(logging.DEBUG):
if sys.version_info
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,8 @@ def test_excel_reader_with_infer_schema(
spark_version = get_spark_version(spark)
if spark_version < (3, 2):
pytest.skip("Excel files are supported on Spark 3.2+ only")
if spark_version >= (3, 5):
pytest.skip("Excel files are not supported on Spark 3.5+ yet")

file_df_connection, source_path, _ = local_fs_file_df_connection_with_path_and_files
df = file_df_dataframe
Expand Down Expand Up @@ -81,6 +83,8 @@ def test_excel_reader_with_options(
spark_version = get_spark_version(spark)
if spark_version < (3, 2):
pytest.skip("Excel files are supported on Spark 3.2+ only")
if spark_version >= (3, 5):
pytest.skip("Excel files are not supported on Spark 3.5+ yet")

local_fs, source_path, _ = local_fs_file_df_connection_with_path_and_files
df = file_df_dataframe
Expand Down Expand Up @@ -117,6 +121,8 @@ def test_excel_writer(
spark_version = get_spark_version(spark)
if spark_version < (3, 2):
pytest.skip("Excel files are supported on Spark 3.2+ only")
if spark_version >= (3, 5):
pytest.skip("Excel files are not supported on Spark 3.5+ yet")

file_df_connection, source_path = local_fs_file_df_connection_with_path
df = file_df_dataframe
Expand Down
Loading