Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOP-9653] Test SparkLocalFS on Spark 3.5 #165

Merged
merged 1 commit into from
Oct 10, 2023
Merged

Conversation

dolfinus
Copy link
Member

@dolfinus dolfinus commented Oct 6, 2023

Change Summary

Related issue number

In #159 I've tested SparkLocalFS on Spark 3.5.0, but discovered that Excel tests are failing, so haven't commited this version to CI test matrix.

Now minimal tests for SparkLocalFS are run on both Spark 3.4.1 and 3.5.0, but Excel tests are temporary disabled on Spark 3.5+ until #161 is closed (this will take a while).

Checklist

  • Commit message and PR title is comprehensive
  • Keep the change as small as possible
  • Unit and integration tests for the changes exist
  • Tests pass on CI and coverage does not decrease
  • Documentation reflects the changes where applicable
  • docs/changelog/next_release/<pull request or issue id>.<change type>.rst file added describing change
    (see CONTRIBUTING.rst for details.)
  • My PR is ready to review.

@dolfinus dolfinus self-assigned this Oct 6, 2023
@dolfinus dolfinus force-pushed the feature/DOP-9653-1 branch from c025e51 to 8f73b41 Compare October 6, 2023 12:40
@dolfinus dolfinus temporarily deployed to test-pypi October 6, 2023 12:40 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Oct 6, 2023

Codecov Report

Merging #165 (0191cfe) into develop (32c37ed) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop     #165      +/-   ##
===========================================
- Coverage    94.33%   94.32%   -0.02%     
===========================================
  Files          209      209              
  Lines         7925     7923       -2     
  Branches      1490     1489       -1     
===========================================
- Hits          7476     7473       -3     
- Misses         326      327       +1     
  Partials       123      123              

see 1 file with indirect coverage changes

@dolfinus dolfinus force-pushed the feature/DOP-9653-1 branch from 8f73b41 to 8b054d6 Compare October 6, 2023 13:17
@dolfinus dolfinus temporarily deployed to test-pypi October 6, 2023 13:17 — with GitHub Actions Inactive
@dolfinus dolfinus marked this pull request as ready for review October 6, 2023 13:19
@dolfinus dolfinus added the ci:skip-changelog Add this label to skip changelog file check label Oct 6, 2023
@dolfinus dolfinus force-pushed the feature/DOP-9653-1 branch from 8b054d6 to 0191cfe Compare October 6, 2023 13:53
@dolfinus dolfinus temporarily deployed to test-pypi October 6, 2023 13:53 — with GitHub Actions Inactive
@dolfinus dolfinus merged commit 0b96036 into develop Oct 10, 2023
31 checks passed
@dolfinus dolfinus deleted the feature/DOP-9653-1 branch October 10, 2023 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:skip-changelog Add this label to skip changelog file check
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants