Feature/standard characteristics #88
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… new test images before pull request
…ssification needs the values tweaked because everything looks so washed out in the pictures
…ssification needs the values tweaked because everything looks so washed out in the pictures
…ssification needs the values tweaked because everything looks so washed out in the pictures
… new test images before pull request
…ssification needs the values tweaked because everything looks so washed out in the pictures
…ssification needs the values tweaked because everything looks so washed out in the pictures
…ssification needs the values tweaked because everything looks so washed out in the pictures
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1
Identifies the type of shape pictured and its color. All code is in vision/odlc/standard_characteristics.py and the function to be called is
id_shape(). I believe that there may be some better method of image pre-processing, so I added optional arguments to the function where you can provide a pre-processed image or the opencv contours of the shape (image still needed in both cases), if already found earlier in the pipeline. The function assumes that the provided image is a cropped box around a shape, so it can identify the type of shape and its color.